From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: connlabels: prefer static lock initialiser
Date: Tue, 13 Aug 2019 12:04:44 +0200 [thread overview]
Message-ID: <20190813100444.xl4yqookc3pnfkgc@salvia> (raw)
In-Reply-To: <20190812114004.23746-1-fw@strlen.de>
On Mon, Aug 12, 2019 at 01:40:04PM +0200, Florian Westphal wrote:
> seen during boot:
> BUG: spinlock bad magic on CPU#2, swapper/0/1
> lock: nf_connlabels_lock+0x0/0x60, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
> Call Trace:
> do_raw_spin_lock+0x14e/0x1b0
> nf_connlabels_get+0x15/0x40
> ct_init_net+0xc4/0x270
> ops_init+0x56/0x1c0
> register_pernet_operations+0x1c8/0x350
> register_pernet_subsys+0x1f/0x40
> tcf_register_action+0x7c/0x1a0
> do_one_initcall+0x13d/0x2d9
>
> Problem is that ct action init function can run before
> connlabels_init(). Lock has not been initialised yet.
>
> Fix it by using a static initialiser.
Applied, thanks Florian.
prev parent reply other threads:[~2019-08-13 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 11:40 [PATCH nf-next] netfilter: connlabels: prefer static lock initialiser Florian Westphal
2019-08-13 10:04 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813100444.xl4yqookc3pnfkgc@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).