From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85277C433FF for ; Tue, 13 Aug 2019 10:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B7172067D for ; Tue, 13 Aug 2019 10:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbfHMKSs (ORCPT ); Tue, 13 Aug 2019 06:18:48 -0400 Received: from correo.us.es ([193.147.175.20]:41498 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727632AbfHMKSs (ORCPT ); Tue, 13 Aug 2019 06:18:48 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 84A91FC5E4 for ; Tue, 13 Aug 2019 12:18:45 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 77B0E6E7A0 for ; Tue, 13 Aug 2019 12:18:45 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6D23A576C8; Tue, 13 Aug 2019 12:18:45 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 55ABEDA7B9; Tue, 13 Aug 2019 12:18:43 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 13 Aug 2019 12:18:43 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.218.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 2D05F4265A32; Tue, 13 Aug 2019 12:18:43 +0200 (CEST) Date: Tue, 13 Aug 2019 12:18:42 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Ander Juaristi Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] meta: Introduce new conditions 'time', 'day' and 'hour' Message-ID: <20190813101842.qcvgaupsteu6wjwz@salvia> References: <20190802072923.21578-1-a@juaristi.eus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802072923.21578-1-a@juaristi.eus> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Aug 02, 2019 at 09:29:23AM +0200, Ander Juaristi wrote: > Signed-off-by: Ander Juaristi > --- > include/linux/netfilter/nf_tables.h | 6 ++++++ > src/expr/meta.c | 5 ++++- This looks good. Please, in your next round, add the prefix to tell what tree this is for. I infer this is for libnftnl, so better if you say something like this: [PATCH libnftnl] meta: add support for time, data, and hour matching Thanks.