From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A05C32750 for ; Tue, 13 Aug 2019 13:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30DC820578 for ; Tue, 13 Aug 2019 13:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbfHMN3B (ORCPT ); Tue, 13 Aug 2019 09:29:01 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:55314 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728346AbfHMN3B (ORCPT ); Tue, 13 Aug 2019 09:29:01 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1hxWrE-0001hG-3t; Tue, 13 Aug 2019 15:29:00 +0200 Date: Tue, 13 Aug 2019 15:29:00 +0200 From: Florian Westphal To: Todd Seidelmann Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf] netfilter: ebtables: Fix argument order to ADD_COUNTER Message-ID: <20190813132900.o73rfe3h6vag7pdv@breakpoint.cc> References: <0330b679-4649-df92-f0d7-a0b5c7dcc87d@linode.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0330b679-4649-df92-f0d7-a0b5c7dcc87d@linode.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Todd Seidelmann wrote: > The ordering of arguments to the x_tables ADD_COUNTER macro > appears to be wrong in ebtables (cf. ip_tables.c, ip6_tables.c, > and arp_tables.c). > > This causes data corruption in the ebtables userspace tools > because they get incorrect packet & byte counts from the kernel. Please resend with a 'Signed-off-by' tag and the 'Fixes:' tag that I provided when I reviewd this patch. It will help stable maintainers to figure out which trees need this fix applied.