From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nftables 1/4] src: fix jumps on bigendian arches
Date: Tue, 13 Aug 2019 21:34:39 +0200 [thread overview]
Message-ID: <20190813193439.domojznfkzp3g7ih@breakpoint.cc> (raw)
In-Reply-To: <20190813192049.enr7yczyngth4s4o@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > char chain[NFT_CHAIN_MAXNAMELEN];
>
> Probably:
>
> chat chain[NFT_CHAIN_MAXNAMELEN + 1] = {};
> to ensure space for \0.
Not sure thats needed, the policy is:
[NFTA_CHAIN_NAME] = { .type = NLA_STRING,
.len = NFT_CHAIN_MAXNAMELEN - 1 },
> > + unsigned int len;
> > +
> > + memset(chain, 0, sizeof(chain));
>
> remove this memset then.
>
> > + len = e->len / BITS_PER_BYTE;
>
> div_round_up() ?
Do we have strings that are not divisible by BITS_PER_BYTE?
> > + if (len >= sizeof(chain))
> > + len = sizeof(chain) - 1;
>
> Probably BUG() here instead if e->len > NFT_CHAIN_MAXNAMELEN? This
> should not happen.
Yes, I can change this.
next prev parent reply other threads:[~2019-08-13 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 18:44 [PATCH nftables 0/4] un-break nftables on big-endian arches Florian Westphal
2019-08-13 18:44 ` [PATCH nftables 1/4] src: fix jumps on bigendian arches Florian Westphal
2019-08-13 19:20 ` Pablo Neira Ayuso
2019-08-13 19:34 ` Florian Westphal [this message]
2019-08-13 19:35 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 2/4] src: parser: fix parsing of chain priority and policy on bigendian Florian Westphal
2019-08-13 19:26 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 3/4] src: mnl: fix setting rcvbuffer size Florian Westphal
2019-08-13 19:26 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 4/4] src: mnl: retry when we hit -ENOBUFS Florian Westphal
2019-08-13 19:34 ` Pablo Neira Ayuso
2019-08-13 19:36 ` Florian Westphal
2019-08-13 19:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813193439.domojznfkzp3g7ih@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).