Netfilter-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [nf-next:master 14/17] include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!"
@ 2019-08-13 22:05 kbuild test robot
  2019-08-14  7:45 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2019-08-13 22:05 UTC (permalink / raw)
  To: Jeremy Sowden; +Cc: kbuild-all, netfilter-devel, coreteam, Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master
head:   105333435b4f3b21ffc325f32fae17719310db64
commit: 2a475c409fe81a76fb26a6b023509d648237bbe6 [14/17] kbuild: remove all netfilter headers from header-test blacklist.
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 2a475c409fe81a76fb26a6b023509d648237bbe6
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from <command-line>:0:0:
>> include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" [-Wcpp]
    #warning "Please update iptables, this file will be removed soon!"
     ^~~~~~~
--
   In file included from <command-line>:0:0:
>> include/uapi/linux/netfilter_ipv4/ipt_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" [-Wcpp]
    #warning "Please update iptables, this file will be removed soon!"
     ^~~~~~~

vim +5 include/uapi/linux/netfilter_ipv6/ip6t_LOG.h

^1da177e4c3f41 include/linux/netfilter_ipv6/ip6t_LOG.h Linus Torvalds     2005-04-16  4  
6939c33a757bd0 include/linux/netfilter_ipv6/ip6t_LOG.h Richard Weinberger 2012-02-10 @5  #warning "Please update iptables, this file will be removed soon!"
6939c33a757bd0 include/linux/netfilter_ipv6/ip6t_LOG.h Richard Weinberger 2012-02-10  6  

:::::: The code at line 5 was first introduced by commit
:::::: 6939c33a757bd006c5e0b8b5fd429fc587a4d0f4 netfilter: merge ipt_LOG and ip6_LOG into xt_LOG

:::::: TO: Richard Weinberger <richard@nod.at>
:::::: CC: Pablo Neira Ayuso <pablo@netfilter.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58706 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [nf-next:master 14/17] include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!"
  2019-08-13 22:05 [nf-next:master 14/17] include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" kbuild test robot
@ 2019-08-14  7:45 ` Pablo Neira Ayuso
  2019-08-14  7:52   ` Jeremy Sowden
  2019-08-14  8:01   ` [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers Jeremy Sowden
  0 siblings, 2 replies; 5+ messages in thread
From: Pablo Neira Ayuso @ 2019-08-14  7:45 UTC (permalink / raw)
  To: Jeremy Sowden; +Cc: kbuild-all, kbuild test robot, netfilter-devel, coreteam

Hi Jeremy,

On Wed, Aug 14, 2019 at 06:05:49AM +0800, kbuild test robot wrote:
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master
> head:   105333435b4f3b21ffc325f32fae17719310db64
> commit: 2a475c409fe81a76fb26a6b023509d648237bbe6 [14/17] kbuild: remove all netfilter headers from header-test blacklist.
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 2a475c409fe81a76fb26a6b023509d648237bbe6
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=sparc64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from <command-line>:0:0:
> >> include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" [-Wcpp]
>     #warning "Please update iptables, this file will be removed soon!"
>      ^~~~~~~

I'd suggest you send me a patch to remove this #warning.

userspace iptables still refer to this header. The intention was to
use xt_LOG.h instead and remove these, but userspace was never
updated.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [nf-next:master 14/17] include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!"
  2019-08-14  7:45 ` Pablo Neira Ayuso
@ 2019-08-14  7:52   ` Jeremy Sowden
  2019-08-14  8:01   ` [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers Jeremy Sowden
  1 sibling, 0 replies; 5+ messages in thread
From: Jeremy Sowden @ 2019-08-14  7:52 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: kbuild-all, kbuild test robot, netfilter-devel, coreteam

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

On 2019-08-14, at 09:45:39 +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 14, 2019 at 06:05:49AM +0800, kbuild test robot wrote:
> > tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/pablo/nf-next.git master
> > head:   105333435b4f3b21ffc325f32fae17719310db64
> > commit: 2a475c409fe81a76fb26a6b023509d648237bbe6 [14/17] kbuild: remove all netfilter headers from header-test blacklist.
> > config: sparc64-allmodconfig (attached as .config)
> > compiler: sparc64-linux-gcc (GCC) 7.4.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 2a475c409fe81a76fb26a6b023509d648237bbe6
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=sparc64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >    In file included from <command-line>:0:0:
> > >> include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" [-Wcpp]
> >     #warning "Please update iptables, this file will be removed soon!"
> >      ^~~~~~~
>
> I'd suggest you send me a patch to remove this #warning.
>
> userspace iptables still refer to this header. The intention was to
> use xt_LOG.h instead and remove these, but userspace was never
> updated.

Was just preparing one to add "#ifndef __KERNEL__" guards to the
warnings.  I'll remove them instead.

J.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers.
  2019-08-14  7:45 ` Pablo Neira Ayuso
  2019-08-14  7:52   ` Jeremy Sowden
@ 2019-08-14  8:01   ` Jeremy Sowden
  2019-08-14 21:37     ` Pablo Neira Ayuso
  1 sibling, 1 reply; 5+ messages in thread
From: Jeremy Sowden @ 2019-08-14  8:01 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: Netfilter Devel, kbuild test robot

There are two netfilter userspace headers which contain deprecation
warnings.  While these headers are not used within the kernel, they are
compiled stand-alone for header-testing.

Pablo informs me that userspace iptables still refer to these headers,
and the intention was to use xt_LOG.h instead and remove these, but
userspace was never updated.

Remove the warnings.

Fixes: 2a475c409fe8 ("kbuild: remove all netfilter headers from header-test blacklist.")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 include/uapi/linux/netfilter_ipv4/ipt_LOG.h  | 2 --
 include/uapi/linux/netfilter_ipv6/ip6t_LOG.h | 2 --
 2 files changed, 4 deletions(-)

diff --git a/include/uapi/linux/netfilter_ipv4/ipt_LOG.h b/include/uapi/linux/netfilter_ipv4/ipt_LOG.h
index 6dec14ba851b..b7cf2c669f40 100644
--- a/include/uapi/linux/netfilter_ipv4/ipt_LOG.h
+++ b/include/uapi/linux/netfilter_ipv4/ipt_LOG.h
@@ -2,8 +2,6 @@
 #ifndef _IPT_LOG_H
 #define _IPT_LOG_H
 
-#warning "Please update iptables, this file will be removed soon!"
-
 /* make sure not to change this without changing netfilter.h:NF_LOG_* (!) */
 #define IPT_LOG_TCPSEQ		0x01	/* Log TCP sequence numbers */
 #define IPT_LOG_TCPOPT		0x02	/* Log TCP options */
diff --git a/include/uapi/linux/netfilter_ipv6/ip6t_LOG.h b/include/uapi/linux/netfilter_ipv6/ip6t_LOG.h
index 7553a434e4da..23e91a9c2583 100644
--- a/include/uapi/linux/netfilter_ipv6/ip6t_LOG.h
+++ b/include/uapi/linux/netfilter_ipv6/ip6t_LOG.h
@@ -2,8 +2,6 @@
 #ifndef _IP6T_LOG_H
 #define _IP6T_LOG_H
 
-#warning "Please update iptables, this file will be removed soon!"
-
 /* make sure not to change this without changing netfilter.h:NF_LOG_* (!) */
 #define IP6T_LOG_TCPSEQ		0x01	/* Log TCP sequence numbers */
 #define IP6T_LOG_TCPOPT		0x02	/* Log TCP options */
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers.
  2019-08-14  8:01   ` [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers Jeremy Sowden
@ 2019-08-14 21:37     ` Pablo Neira Ayuso
  0 siblings, 0 replies; 5+ messages in thread
From: Pablo Neira Ayuso @ 2019-08-14 21:37 UTC (permalink / raw)
  To: Jeremy Sowden; +Cc: Netfilter Devel, kbuild test robot

On Wed, Aug 14, 2019 at 09:01:28AM +0100, Jeremy Sowden wrote:
> There are two netfilter userspace headers which contain deprecation
> warnings.  While these headers are not used within the kernel, they are
> compiled stand-alone for header-testing.
> 
> Pablo informs me that userspace iptables still refer to these headers,
> and the intention was to use xt_LOG.h instead and remove these, but
> userspace was never updated.
> 
> Remove the warnings.

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 22:05 [nf-next:master 14/17] include/uapi/linux/netfilter_ipv6/ip6t_LOG.h:5:2: warning: #warning "Please update iptables, this file will be removed soon!" kbuild test robot
2019-08-14  7:45 ` Pablo Neira Ayuso
2019-08-14  7:52   ` Jeremy Sowden
2019-08-14  8:01   ` [PATCH nf-next] netfilter: remove deprecation warnings from uapi headers Jeremy Sowden
2019-08-14 21:37     ` Pablo Neira Ayuso

Netfilter-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \
		netfilter-devel@vger.kernel.org netfilter-devel@archiver.kernel.org
	public-inbox-index netfilter-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox