From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C584EC433FF for ; Wed, 14 Aug 2019 13:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96AA02064A for ; Wed, 14 Aug 2019 13:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfHNN4u (ORCPT ); Wed, 14 Aug 2019 09:56:50 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:34174 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbfHNN4u (ORCPT ); Wed, 14 Aug 2019 09:56:50 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1hxtlf-00034t-KL; Wed, 14 Aug 2019 15:56:47 +0200 Date: Wed, 14 Aug 2019 15:56:47 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: Ander Juaristi , netfilter-devel@vger.kernel.org Subject: Re: [PATCH v3] netfilter: nft_dynset: support for element deletion Message-ID: <20190814135647.2hyfy6boqg5k5x7e@breakpoint.cc> References: <20190813065849.4745-1-a@juaristi.eus> <20190814081747.j3gg57copo2zpinm@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814081747.j3gg57copo2zpinm@salvia> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > On Tue, Aug 13, 2019 at 08:58:49AM +0200, Ander Juaristi wrote: > > This patch implements the delete operation from the ruleset. > > > > It implements a new delete() function in nft_set_rhash. It is simpler > > to use than the already existing remove(), because it only takes the set > > and the key as arguments, whereas remove() expects a full > > nft_set_elem structure. > > Userspace patches for this? Thanks. Yes, please also add at least one test case -- thanks. As a reminder, this needs a small patch to libnftnl to avoid [ dynset unknown reg_key 1 set y timeout 0ms ]