From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F2CC3A5A0 for ; Mon, 19 Aug 2019 20:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 102C422CE8 for ; Mon, 19 Aug 2019 20:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="kjpnuPoN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbfHSU2H (ORCPT ); Mon, 19 Aug 2019 16:28:07 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36341 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728055AbfHSU2H (ORCPT ); Mon, 19 Aug 2019 16:28:07 -0400 Received: by mail-qt1-f193.google.com with SMTP id z4so3425956qtc.3 for ; Mon, 19 Aug 2019 13:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=pJvcVeGyUeIVDpO5RArvDs7NS7qFRcy6zBiCjIhFyCU=; b=kjpnuPoNhgCzQoP6p/RTLE23OKutNFwh0RaCBaUpPKFCL/a9OlcZdO9kjDsTBb2lBN qvirKyldJzmUhiECW5COmsf4jBRys0ZQ7p/od9SWMCl0pcokhQDetq3HoOy/PoPsPnTj mHX+vTPjJBwoAcaZpXQnYN6G393UKNRfTj184M1E8o+tAuyDjBkMcdM+lPNoMS2jXcso Odl57Wm9bO72RjCeQQIfzG1bz2n+T3ni70uv3D4NxyI7FD8d/fvRuJmiex1KH+kUJXQH YJbNhAQKTab0U21jVJchUfWoGtyqkehVeG3fcX8/e+Hid9d8rWJWD7GLFC+xxrueF5yY Gzyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=pJvcVeGyUeIVDpO5RArvDs7NS7qFRcy6zBiCjIhFyCU=; b=I2arPLaVSGhTDv0J0k8LEb2vZxUN/1mA9hv3eDm40gpgLVNyRlSiS1GaU7GKyO8HhP HpObiLvzT1ocwgM21ponN5SIcAS+pkwFufAitqysnLdpwheNbMlknZiuHI+DHCTFuyQO YzKkMsO9Nu0fSU4Id+wJf/kpz2eGvSUp1dTnDhy1BWEW4eU0H+4oEcDSrnD7B/RL74u/ fbpnvAHRqSQrhnGZvuiA9ORkto+XTg653JaCnlEMhfPJFTX6kgyUt4CHjUcOqxud3bOs Ce+FoBMmo3QZvaqno/VyMf3WyT0KyKD44S7Rsrea9ezLaLbqMeOKoUa7wKJQUIzCUTtk 3qRA== X-Gm-Message-State: APjAAAVAg2Vqv2DepMOApCa01ZSnyuIRKUVvslwXo0hWpTcRwtkqJX0Y AGPv/4m+QhrCEuEbICMJATDlow== X-Google-Smtp-Source: APXvYqztOLbRTFoVwU3R0+mvN+1PxMzx6yaEI7zKkrws343fdleTwrioRPo5ZqAbVsnLmOxVIg0OSQ== X-Received: by 2002:ac8:7b97:: with SMTP id p23mr23070680qtu.357.1566246486693; Mon, 19 Aug 2019 13:28:06 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y23sm7379429qki.118.2019.08.19.13.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 13:28:06 -0700 (PDT) Date: Mon, 19 Aug 2019 13:27:57 -0700 From: Jakub Kicinski To: Vlad Buslov Cc: wenxu , David Miller , Jiri Pirko , "pablo@netfilter.org" , "netfilter-devel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block Message-ID: <20190819132757.0d00d34d@cakuba.netronome.com> In-Reply-To: References: <1565140434-8109-1-git-send-email-wenxu@ucloud.cn> <1565140434-8109-6-git-send-email-wenxu@ucloud.cn> <20190816105627.57c1c2aa@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, 19 Aug 2019 07:26:07 +0000, Vlad Buslov wrote: > On Fri 16 Aug 2019 at 20:56, Jakub Kicinski wrote: > > Hi Vlad! > > > > While looking into this, would you mind also add the missing > > flow_block_cb_is_busy() calls in the indirect handlers in the drivers? > > > > LMK if you're too busy, I don't want this to get forgotten :) > > Hi Jakub, > > I've checked the code and it looks like only nfp driver is affected: > > - I added check in nfp to lookup cb_priv with > nfp_flower_indr_block_cb_priv_lookup() and call > flow_block_cb_is_busy() if cb_priv exists. > > - In mlx5 en_rep.c there is already a check that indr_priv exists, so > trying to lookup block_cb->cb_indent==indr_priv is redundant. > > - Switch drivers (mlxsw and ocelot) take reference to block_cb on > FLOW_BLOCK_BIND, so they should not require any modifications. > > Tell me if I missed anything. Sending the patch for nfp. Ah, that sounds plausible, I've only checked the nfp driver.