netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@ucloud.cn
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v3] meta: add ibrpvid and ibrvproto support
Date: Wed, 21 Aug 2019 11:14:49 +0200	[thread overview]
Message-ID: <20190821091449.qzf4nnprg7fkhx53@salvia> (raw)
In-Reply-To: <1565961026-27741-1-git-send-email-wenxu@ucloud.cn>

On Fri, Aug 16, 2019 at 09:10:26PM +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> This allows you to match the bridge pvid and vlan protocol, for
> instance:
> 
> nft add rule bridge firewall zones meta ibrvproto 0x8100
> nft add rule bridge firewall zones meta ibrpvid 100

Still one more nitpick when running tests/py:

bridge/meta.t: WARNING: line 7: 'add rule bridge test-bridge input
meta ibrvproto 0x8100': 'meta ibrvproto 0x8100' mismatches 'meta
ibrvproto 33024'

Please amend and send v4.

      reply	other threads:[~2019-08-21  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 13:10 [PATCH nft v3] meta: add ibrpvid and ibrvproto support wenxu
2019-08-21  9:14 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821091449.qzf4nnprg7fkhx53@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).