netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: David Miller <davemdavemloft!net@strlen.de>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot
Date: Wed, 28 Aug 2019 10:19:42 +0200	[thread overview]
Message-ID: <20190828081942.isdjcdvcqok2a6zz@salvia> (raw)
In-Reply-To: <20190827215836.GA10942@strlen.de>

On Tue, Aug 27, 2019 at 11:58:36PM +0200, Florian Westphal wrote:
> David Miller <davemdavemloft!net> wrote:
> > From: Leonardo Bras <leonardo@linux.ibm.com>
> > Date: Tue, 27 Aug 2019 14:34:14 -0300
> > 
> > > I could reproduce this bug on a host ('ipv6.disable=1') starting a
> > > guest with a virtio-net interface with 'filterref' over a virtual
> > > bridge. It crashes the host during guest boot (just before login).
> > > 
> > > By that I could understand that a guest IPv6 network traffic
> > > (viavirtio-net) may cause this kernel panic.
> > 
> > Really this is bad and I suspected bridging to be involved somehow.
> 
> Thats a good point -- Leonardo, is the
> "net.bridge.bridge-nf-call-ip6tables" sysctl on?
> 
> As much as i'd like to send a patch to remove br_netfilter, I fear
> we can't even stop passing ipv6 packets up to netfilter if
> ipv6.disable=1 is set because users might be using ip6tables for
> bridged traffic.

If the br_netfilter module is in placed, then it's probably better to
perform this check from there.

  reply	other threads:[~2019-08-28  8:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 14:15 [PATCH v2 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if IPv6 is disabled on boot Leonardo Bras
2019-08-27 10:35 ` Pablo Neira Ayuso
2019-08-27 17:34   ` Leonardo Bras
2019-08-27 18:51     ` Pablo Neira Ayuso
2019-08-27 18:55       ` Leonardo Bras
2019-08-27 21:19     ` David Miller
2019-08-27 21:58       ` Florian Westphal
2019-08-28  8:19         ` Pablo Neira Ayuso [this message]
2019-08-28 10:17           ` Florian Westphal
2019-08-29 20:04 ` Leonardo Bras
2019-08-29 20:29   ` Leonardo Bras
2019-08-29 20:58     ` Florian Westphal
2019-08-30 14:15       ` Leonardo Bras
2019-08-30 15:48       ` Leonardo Bras
2019-08-30 15:58         ` Florian Westphal
2019-08-30 18:16       ` Leonardo Bras
2019-08-29 20:29   ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828081942.isdjcdvcqok2a6zz@salvia \
    --to=pablo@netfilter.org \
    --cc=davemdavemloft!net@strlen.de \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).