From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Eric Garver <eric@garver.life>
Subject: Re: [PATCH nft] tests: shell: check that rule add with index works with echo
Date: Wed, 4 Sep 2019 10:13:37 +0200 [thread overview]
Message-ID: <20190904081337.GH25650@orbyte.nwl.cc> (raw)
In-Reply-To: <20190903232713.14394-1-eric@garver.life>
Pablo,
On Tue, Sep 03, 2019 at 07:27:13PM -0400, Eric Garver wrote:
> If --echo is used the rule cache will not be populated. This causes
> rules added using the "index" keyword to be simply appended to the
> chain. The bug was introduced in commit 3ab02db5f836 ("cache: add
> NFT_CACHE_UPDATE and NFT_CACHE_FLUSHED flags").
>
> Signed-off-by: Eric Garver <eric@garver.life>
> ---
> I think the issue is in cache_evaluate(). It sets the flags to
> NFT_CACHE_FULL and then bails early, but I'm not sure of the best way to
> fix it. So I'll start by submitting a test case. :)
In 3ab02db5f836a ("cache: add NFT_CACHE_UPDATE and NFT_CACHE_FLUSHED
flags"), you introduced NFT_CACHE_UPDATE to control whether
rule_evaluate() should call rule_cache_update(), probably assuming the
latter function merely changes cache depending on current command. In
fact, this function also links rules if needed (see call to
link_rules()).
The old code you replaced also did not always call rule_cache_update(),
but that was merely for sanity: If cache doesn't contain rules, there is
no point in updating it with added/replaced/removed rules. The implicit
logic is if we saw a rule command with 'index' reference, cache would be
completed up to rule level (because of the necessary index to handle
translation).
I'm not sure why you introduced NFT_CACHE_UPDATE in the first place, but
following my logic (and it seems to serve no other purpose) I would set
that flag whenever NFT_CACHE_RULE_BIT gets set. So IMHO,
NFT_CACHE_UPDATE is redundant.
Cheers, Phil
next prev parent reply other threads:[~2019-09-04 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 23:27 [PATCH nft] tests: shell: check that rule add with index works with echo Eric Garver
2019-09-04 8:13 ` Phil Sutter [this message]
2019-09-04 19:17 ` Pablo Neira Ayuso
2019-09-04 19:31 ` Pablo Neira Ayuso
2019-09-05 15:54 ` Pablo Neira Ayuso
2019-09-05 16:13 ` Eric Garver
2019-09-05 17:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904081337.GH25650@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).