From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] parser_bison: Fix 'exists' keyword on Big Endian
Date: Fri, 13 Sep 2019 20:35:47 +0200 [thread overview]
Message-ID: <20190913183547.GB9943@orbyte.nwl.cc> (raw)
In-Reply-To: <20190913153549.GB10656@breakpoint.cc>
Hi,
On Fri, Sep 13, 2019 at 05:35:49PM +0200, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > - BYTEORDER_HOST_ENDIAN, 1, buf);
> > + BYTEORDER_HOST_ENDIAN,
> > + sizeof(char) * BITS_PER_BYTE, buf);
>
> You can omit the sizeof(char), its always 1. Otherwise this loooks good to me.
OK, I'll send a v2.
Thanks, Phil
prev parent reply other threads:[~2019-09-13 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 15:32 [nft PATCH] parser_bison: Fix 'exists' keyword on Big Endian Phil Sutter
2019-09-13 15:35 ` Florian Westphal
2019-09-13 18:35 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913183547.GB9943@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).