Netfilter-Devel Archive on
 help / color / Atom feed
From: Phil Sutter <>
To: Florian Westphal <>
Cc: Pablo Neira Ayuso <>,
Subject: Re: [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian
Date: Fri, 13 Sep 2019 22:56:22 +0200
Message-ID: <> (raw)
In-Reply-To: <>


On Fri, Sep 13, 2019 at 10:53:44PM +0200, Florian Westphal wrote:
> Phil Sutter <> wrote:
> > Size value passed to constant_expr_alloc() must correspond with actual
> > data size, otherwise wrong portion of data will be taken later when
> > serializing into netlink message.
> > 
> > Booleans require really just a bit, but make type of boolean_keys be
> > uint8_t (introducing new 'val8' name for it) and pass the data length
> > using sizeof() to avoid any magic numbers.
> > 
> > While being at it, fix len value in parser_json.c as well although it
> > worked before due to the value being rounded up to the next multiple of
> > 8.
> Looks good, thanks Phil.

So that's an ACK? :)

Cheers, Phil

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 18:44 Phil Sutter
2019-09-13 20:53 ` Florian Westphal
2019-09-13 20:56   ` Phil Sutter [this message]
2019-09-13 22:35     ` Florian Westphal

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netfilter-Devel Archive on

Archives are clonable:
	git clone --mirror netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ \
	public-inbox-index netfilter-devel

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox