From: Jeremy Sowden <jeremy@azazel.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
Sebastian Priebe <sebastian.priebe@de.sii.group>
Subject: [PATCH nftables v2 0/2] Add Linenoise support to the CLI.
Date: Tue, 24 Sep 2019 08:40:53 +0100 [thread overview]
Message-ID: <20190924074055.4146-1-jeremy@azazel.net> (raw)
Sebastian Priebe [0] requested Linenoise support for the CLI as an
alternative to Readline, so I thought I'd have a go at providing it.
Linenoise is a minimal, zero-config, BSD licensed, Readline replacement
used in Redis, MongoDB, and Android [1].
0 - https://lore.kernel.org/netfilter-devel/4df20614cd10434b9f91080d0862dd0c@de.sii.group/
1 - https://github.com/antirez/linenoise/
By default, the CLI continues to be build using Readline, but passing
`--with-cli=linenoise` instead causes Linenoise to be used instead.
`nft -v` has been extended to display what CLI implementation was built
and whether mini-gmp was used.
Changes since v1:
* dropped the linenoise source from the nftables tree and added an
`AC_CHECK_LIB` check instead.
Changes since RFC:
* two tidy-up patches dropped because they have already been applied;
* source now added to include/ and src/;
* tests/build/run-tests.sh updated to test `--with-cli=linenoise`;
* `nft -v` extended.
Jeremy Sowden (2):
cli: add linenoise CLI implementation.
main: add more information to `nft -v`.
configure.ac | 17 ++++++++---
include/cli.h | 2 +-
src/Makefile.am | 3 ++
src/cli.c | 64 ++++++++++++++++++++++++++++++++++------
src/main.c | 28 ++++++++++++++++--
tests/build/run-tests.sh | 4 +--
6 files changed, 100 insertions(+), 18 deletions(-)
--
2.23.0
next reply other threads:[~2019-09-24 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 7:40 Jeremy Sowden [this message]
2019-09-24 7:40 ` [PATCH nftables v2 1/2] cli: add linenoise CLI implementation Jeremy Sowden
2019-10-15 8:32 ` Pablo Neira Ayuso
2019-10-16 10:55 ` Jeremy Sowden
2019-10-16 12:19 ` Pablo Neira Ayuso
2019-10-16 13:34 ` Jeremy Sowden
2019-09-24 7:40 ` [PATCH nftables v2 2/2] main: add more information to `nft -v` Jeremy Sowden
2019-09-26 7:35 ` [PATCH nftables v2 0/2] Add Linenoise support to the CLI Phil Sutter
2019-10-15 7:23 ` AW: " Priebe, Sebastian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924074055.4146-1-jeremy@azazel.net \
--to=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sebastian.priebe@de.sii.group \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).