From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C45C432C2 for ; Wed, 25 Sep 2019 21:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C327B2146E for ; Wed, 25 Sep 2019 21:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbfIYVsA (ORCPT ); Wed, 25 Sep 2019 17:48:00 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:45972 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfIYVsA (ORCPT ); Wed, 25 Sep 2019 17:48:00 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1iDF8f-0005Xf-Vh; Wed, 25 Sep 2019 23:47:58 +0200 Date: Wed, 25 Sep 2019 23:47:57 +0200 From: Phil Sutter To: Florian Westphal Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH v2 01/24] xtables_error() does not return Message-ID: <20190925214757.GE22129@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20190925212605.1005-1-phil@nwl.cc> <20190925212605.1005-2-phil@nwl.cc> <20190925213115.GA12491@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925213115.GA12491@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 25, 2019 at 11:31:15PM +0200, Florian Westphal wrote: > Phil Sutter wrote: > > It's a define which resolves into a callback which in turn is declared > > with noreturn attribute. It will never return, therefore drop all > > explicit exit() calls or other dead code immediately following it. > > > > Signed-off-by: Phil Sutter > > Acked-by: Florian Westphal > > Feel free to push this already. DONE. :) Thanks, Phil