From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libmnl] src: fix doxygen function documentation
Date: Thu, 26 Sep 2019 10:05:58 +1000 [thread overview]
Message-ID: <20190926000558.GA27134@dimstar.local.net> (raw)
In-Reply-To: <20190925131418.7711-1-ffmancera@riseup.net>
On Wed, Sep 25, 2019 at 03:14:19PM +0200, Fernando Fernandez Mancera wrote:
> Currently clang requires EXPORT_SYMBOL() to be above the function
> implementation. At the same time doxygen is not generating the proper
> documentation because of that.
>
> This patch solves that problem but EXPORT_SYMBOL looks less like the Linux
> kernel way exporting symbols.
>
> Reported-by: Duncan Roe <duncan_roe@optusnet.com.au>
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
> ---
> src/attr.c | 145 +++++++++++++++++++++----------------------------
> src/callback.c | 14 ++---
> src/internal.h | 3 +-
> src/nlmsg.c | 68 +++++++++--------------
> src/socket.c | 42 ++++++--------
> 5 files changed, 113 insertions(+), 159 deletions(-)
>
Why do we need EXPORT_SYMBOL anyway?
Cheers ... Duncan.
next prev parent reply other threads:[~2019-09-26 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 13:14 [PATCH libmnl] src: fix doxygen function documentation Fernando Fernandez Mancera
2019-09-26 0:05 ` Duncan Roe [this message]
2019-09-26 8:37 ` Pablo Neira Ayuso
2019-09-30 14:17 ` Pablo Neira Ayuso
2019-10-06 10:55 ` Duncan Roe
2019-10-06 17:50 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926000558.GA27134@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).