From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448F7C32792 for ; Mon, 30 Sep 2019 14:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12B2A20679 for ; Mon, 30 Sep 2019 14:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731225AbfI3OR6 (ORCPT ); Mon, 30 Sep 2019 10:17:58 -0400 Received: from correo.us.es ([193.147.175.20]:35244 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730923AbfI3OR6 (ORCPT ); Mon, 30 Sep 2019 10:17:58 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 2C060C1D55 for ; Mon, 30 Sep 2019 16:17:54 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1C431BAACC for ; Mon, 30 Sep 2019 16:17:54 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 11B44CE17F; Mon, 30 Sep 2019 16:17:54 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 057DAB8004; Mon, 30 Sep 2019 16:17:52 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 30 Sep 2019 16:17:52 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D9AA942EF9E1; Mon, 30 Sep 2019 16:17:51 +0200 (CEST) Date: Mon, 30 Sep 2019 16:17:53 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Fernando Fernandez Mancera Cc: netfilter-devel@vger.kernel.org, Duncan Roe Subject: Re: [PATCH libmnl] src: fix doxygen function documentation Message-ID: <20190930141753.6wxuweyyspeldfx4@salvia> References: <20190925131418.7711-1-ffmancera@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925131418.7711-1-ffmancera@riseup.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 25, 2019 at 03:14:19PM +0200, Fernando Fernandez Mancera wrote: > Currently clang requires EXPORT_SYMBOL() to be above the function > implementation. At the same time doxygen is not generating the proper > documentation because of that. > > This patch solves that problem but EXPORT_SYMBOL looks less like the Linux > kernel way exporting symbols. Applied, thanks.