From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Duncan Roe <duncan_roe@optusnet.com.au>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue] BUG: src: Fix UDP checksum calculation
Date: Mon, 30 Sep 2019 16:28:40 +0200 [thread overview]
Message-ID: <20190930142840.l6wsena3hfki56qn@salvia> (raw)
In-Reply-To: <20190927121838.7680-1-duncan_roe@optusnet.com.au>
On Fri, Sep 27, 2019 at 10:18:38PM +1000, Duncan Roe wrote:
> The level 4 protocol is part of the UDP and TCP calculations.
> nfq_checksum_tcpudp_ipv4() was using IPPROTO_TCP in this calculation,
> which gave the wrong answer for UDP.
Thanks Duncan, I sent this patch to fix IPv6 too:
https://patchwork.ozlabs.org/patch/1169407/
next prev parent reply other threads:[~2019-09-30 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 12:18 [PATCH libnetfilter_queue] BUG: src: Fix UDP checksum calculation Duncan Roe
2019-09-30 14:28 ` Pablo Neira Ayuso [this message]
2019-10-01 1:28 ` Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930142840.l6wsena3hfki56qn@salvia \
--to=pablo@netfilter.org \
--cc=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).