netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Duncan Roe <duncan_roe@optusnet.com.au>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue 0/5] clang and documentation updates
Date: Tue, 8 Oct 2019 12:27:46 +0200	[thread overview]
Message-ID: <20191008102746.h72le7hizrxqa4j5@salvia> (raw)
In-Reply-To: <20191008004948.25632-1-duncan_roe@optusnet.com.au>

On Tue, Oct 08, 2019 at 11:49:43AM +1100, Duncan Roe wrote:
> This series is a mixture of patches to enable clang build and correct / insert
> doxygen comments. It ended up that way after git merges of local branches where
> they were originally developed.
> 
> Hopefully they are all uncontroversial so can just be applied.

Series applied, thanks.

I have just mangled "src: Enable clang build" not to split the
function definition from its return value, it's a personal preference,
I like to git grep for function definitions occasionally when
searching for symbols. This is something in between your original
proposal and what it's done in libmnl.

Thanks.

      parent reply	other threads:[~2019-10-08 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  0:49 [PATCH libnetfilter_queue 0/5] clang and documentation updates Duncan Roe
2019-10-08  0:49 ` [PATCH libnetfilter_queue 1/5] src: doc: Miscellaneous updates Duncan Roe
2019-10-08  0:49 ` [PATCH libnetfilter_queue 2/5] src: Enable clang build Duncan Roe
2019-10-08  0:49 ` [PATCH libnetfilter_queue 3/5] doxygen: remove EXPORT_SYMBOL from the output Duncan Roe
2019-10-08  0:49 ` [PATCH libnetfilter_queue 4/5] src: Fix invalid conversion specifier Duncan Roe
2019-10-08  0:49 ` [PATCH libnetfilter_queue 5/5] src: doc: Minor fix Duncan Roe
2019-10-08 10:27 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008102746.h72le7hizrxqa4j5@salvia \
    --to=pablo@netfilter.org \
    --cc=duncan_roe@optusnet.com.au \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).