From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnfnetlink 1/1] src: Minimally resurrect doxygen documentation
Date: Wed, 23 Oct 2019 22:48:36 +0200 [thread overview]
Message-ID: <20191023204836.ws4rv55f2dczhq2q@salvia> (raw)
In-Reply-To: <20191023153142.GB5848@dimstar.local.net>
On Thu, Oct 24, 2019 at 02:31:42AM +1100, Duncan Roe wrote:
> On Wed, Oct 23, 2019 at 01:13:46PM +0200, Pablo Neira Ayuso wrote:
> > On Mon, Oct 14, 2019 at 01:02:23PM +1100, Duncan Roe wrote:
> > > The documentation was written in the days before doxygen required groups or even
> > > doxygen.cfg, so create doxygen.cfg.in and introduce one \defgroup per source
> > > file, encompassing pretty-much the whole file.
> > >
> [...]
> > >
> >
> > I'm ambivalent about this, it's been up on the table for a while.
> >
> > This library is rather old, and new applications should probably
> > be based instead used libmnl, which is a better choice.
> >
> The thing is, the Deprecated functions in libnetfilter_queue are much better
> documented than the newer functions and that documentation refers to
> libnfnetlink functions.
Would you help me get better the documentation for the new
libnetfilter_queue API? I'll be trying to address your questions
timely in case you decide to enroll in such endeavor.
> So I think that while the deprecated functions are documented, you should really
> have documentation for the old library they use.
Are you refering to libnfnetlink or libnetfilter_queue in this case?
If you insist on documenting libnfnetlink, I'll be fine with it, no
worries.
> BTW, ldd of my app shows libnfnetlink.so although it doesn't use any deprecated
> functions. Is that expected?
Yes, there is still code in the libraries that refer to libnfnetlink.
Replacing some of that code should be feasible via libmnl, it is a
task that has been in my TODO list for long time. There's always
something with more priority in the queue.
next prev parent reply other threads:[~2019-10-23 20:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 2:02 [PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation Duncan Roe
2019-10-14 2:02 ` [PATCH libnfnetlink 1/1] src: " Duncan Roe
2019-10-23 11:13 ` Pablo Neira Ayuso
2019-10-23 15:12 ` Duncan Roe
2019-10-23 15:58 ` Jeremy Sowden
2019-10-23 20:55 ` Pablo Neira Ayuso
2019-10-23 15:31 ` Duncan Roe
2019-10-23 20:48 ` Pablo Neira Ayuso [this message]
2019-10-24 23:51 ` Duncan Roe
2019-10-26 7:40 ` Duncan Roe
2019-10-26 11:54 ` Pablo Neira Ayuso
2019-10-26 5:19 ` Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 0/2] " Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 1/2] " Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 2/2] Make it clear that this library is deprecated Duncan Roe
2019-10-27 8:49 ` [PATCH libnfnetlink v3 0/2] Minimally resurrect doxygen documentation Duncan Roe
2019-10-27 8:49 ` [PATCH libnfnetlink v3 1/2] " Duncan Roe
2019-11-04 17:28 ` Pablo Neira Ayuso
2019-10-27 8:49 ` [PATCH libnfnetlink v3 2/2] Make it clear that this library is deprecated Duncan Roe
2019-11-04 17:28 ` Pablo Neira Ayuso
2019-10-15 22:52 ` [PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023204836.ws4rv55f2dczhq2q@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).