From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH v2 00/10] Reduce code size around arptables-nft
Date: Mon, 28 Oct 2019 16:48:08 +0100 [thread overview]
Message-ID: <20191028154818.31257-1-phil@nwl.cc> (raw)
A review of xtables-arp.c exposed a significant amount of dead, needless
or duplicated code. This series deals with some low hanging fruits. Most
of the changes affect xtables-arp.c and nft-arp.c only, but where common
issues existed or code was to be shared, other files are touched as
well.
Changes since v1:
- Add missing inverse_for_options array adjustments to patch 7.
Phil Sutter (10):
ip6tables, xtables-arp: Drop unused struct pprot
xshared: Share a common add_command() implementation
xshared: Share a common implementation of parse_rulenumber()
Merge CMD_* defines
xtables-arp: Drop generic_opt_check()
Replace TRUE/FALSE with true/false
xtables-arp: Integrate OPT_* defines into xshared.h
xtables-arp: Drop some unused variables
xtables-arp: Use xtables_parse_interface()
nft-arp: Use xtables_print_mac_and_mask()
iptables/ip6tables.c | 73 +-----------
iptables/iptables.c | 64 +----------
iptables/nft-arp.c | 31 +----
iptables/nft-shared.h | 17 ---
iptables/xshared.c | 39 +++++++
iptables/xshared.h | 32 ++++++
iptables/xtables-arp.c | 255 ++++-------------------------------------
iptables/xtables.c | 48 +-------
8 files changed, 107 insertions(+), 452 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-28 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 15:48 Phil Sutter [this message]
2019-10-28 15:48 ` [iptables PATCH v2 01/10] ip6tables, xtables-arp: Drop unused struct pprot Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 02/10] xshared: Share a common add_command() implementation Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 03/10] xshared: Share a common implementation of parse_rulenumber() Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 04/10] Merge CMD_* defines Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 05/10] xtables-arp: Drop generic_opt_check() Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 06/10] Replace TRUE/FALSE with true/false Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 07/10] xtables-arp: Integrate OPT_* defines into xshared.h Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 08/10] xtables-arp: Drop some unused variables Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 09/10] xtables-arp: Use xtables_parse_interface() Phil Sutter
2019-10-28 15:48 ` [iptables PATCH v2 10/10] nft-arp: Use xtables_print_mac_and_mask() Phil Sutter
2019-10-30 8:24 ` [iptables PATCH v2 00/10] Reduce code size around arptables-nft Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028154818.31257-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).