From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marvin Schmidt <marvin_schmidt@gmx.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 1/1] flowtable: Fix symbol export for clang
Date: Thu, 31 Oct 2019 14:32:39 +0100 [thread overview]
Message-ID: <20191031133239.4qd57erktakizd53@salvia> (raw)
In-Reply-To: <20191031083706.6867-1-marvin_schmidt@gmx.net>
On Thu, Oct 31, 2019 at 09:37:07AM +0100, Marvin Schmidt wrote:
> clang does not allow attribute declarations after definitions:
>
> flowtable.c:41:1: warning: attribute declaration must precede definition [-Wignored-attributes]
> EXPORT_SYMBOL(nftnl_flowtable_alloc);
> ^
> ../include/utils.h:13:41: note: expanded from macro 'EXPORT_SYMBOL'
> # define EXPORT_SYMBOL(x) typeof(x) (x) __visible;
> ^
> ../include/utils.h:12:35: note: expanded from macro '__visible'
> # define __visible __attribute__((visibility("default")))
> ^
> flowtable.c:37:25: note: previous definition is here
> struct nftnl_flowtable *nftnl_flowtable_alloc(void)
>
> Move attribute declarations before the symbol definitions just like
> it's done in other source files
Applied, thanks.
prev parent reply other threads:[~2019-10-31 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 8:37 [libnftnl PATCH 1/1] flowtable: Fix symbol export for clang Marvin Schmidt
2019-10-31 13:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031133239.4qd57erktakizd53@salvia \
--to=pablo@netfilter.org \
--cc=marvin_schmidt@gmx.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).