From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 2/2] Deprecate untyped data setters
Date: Thu, 31 Oct 2019 14:43:21 +0100 [thread overview]
Message-ID: <20191031134321.GC8531@orbyte.nwl.cc> (raw)
In-Reply-To: <20191031124920.4p2frkvfwgktaxqz@salvia>
On Thu, Oct 31, 2019 at 01:49:20PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Oct 30, 2019 at 06:49:48PM +0100, Phil Sutter wrote:
> > These functions make assumptions on size of passed data pointer and
> > therefore tend to hide programming mistakes. Instead either one of the
> > type-specific setters or the generic *_set_data() setter should be used.
>
> Please, confirm that the existing iptables / nft codebase will not hit
> compilation warnings because of deprecated functions.
Yes, current code base does not use those functions.
Cheers, Phil
next prev parent reply other threads:[~2019-10-31 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 17:49 [libnftnl PATCH 1/2] libnftnl.map: Export nftnl_{obj,flowtable}_set_data() Phil Sutter
2019-10-30 17:49 ` [libnftnl PATCH 2/2] Deprecate untyped data setters Phil Sutter
2019-10-31 12:49 ` Pablo Neira Ayuso
2019-10-31 13:43 ` Phil Sutter [this message]
2019-10-31 13:52 ` Pablo Neira Ayuso
2019-10-31 12:12 ` [libnftnl PATCH 1/2] libnftnl.map: Export nftnl_{obj,flowtable}_set_data() Phil Sutter
2019-10-31 12:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031134321.GC8531@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).