From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3E3C5DF63 for ; Wed, 6 Nov 2019 14:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFDBB217F5 for ; Wed, 6 Nov 2019 14:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728525AbfKFOhi (ORCPT ); Wed, 6 Nov 2019 09:37:38 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:42890 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbfKFOhi (ORCPT ); Wed, 6 Nov 2019 09:37:38 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iSMRD-000856-0G; Wed, 06 Nov 2019 15:37:35 +0100 Date: Wed, 6 Nov 2019 15:37:34 +0100 From: Florian Westphal To: Jeremy Sowden Cc: Pablo Neira Ayuso , Netfilter Devel Subject: Re: [PATCH] src: add `set_is_meter` helper. Message-ID: <20191106143734.GO876@breakpoint.cc> References: <20191105213154.23929-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191105213154.23929-1-jeremy@azazel.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Jeremy Sowden wrote: > The sets constructed for meters are flagged as anonymous and dynamic. > However, in some places there are only checks that they are dynamic, > which can lead to normal sets being classified as meters. Applied, thanks for including a test case.