* [nft PATCH] doc: Drop incorrect requirement for nft configs @ 2019-11-05 13:14 Phil Sutter 2019-11-06 11:47 ` Pablo Neira Ayuso 0 siblings, 1 reply; 6+ messages in thread From: Phil Sutter @ 2019-11-05 13:14 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel The shebang is not needed in files to be used with --file parameter. Signed-off-by: Phil Sutter <phil@nwl.cc> --- doc/nft.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/nft.txt b/doc/nft.txt index ed2157638032a..c53327e25833d 100644 --- a/doc/nft.txt +++ b/doc/nft.txt @@ -85,8 +85,7 @@ For a full summary of options, run *nft --help*. *-f*:: *--file 'filename'*:: - Read input from 'filename'. If 'filename' is -, read from stdin. + - nft scripts must start *#!/usr/sbin/nft -f* + Read input from 'filename'. If 'filename' is -, read from stdin. *-i*:: *--interactive*:: -- 2.23.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [nft PATCH] doc: Drop incorrect requirement for nft configs 2019-11-05 13:14 [nft PATCH] doc: Drop incorrect requirement for nft configs Phil Sutter @ 2019-11-06 11:47 ` Pablo Neira Ayuso 2019-11-06 14:19 ` Phil Sutter 0 siblings, 1 reply; 6+ messages in thread From: Pablo Neira Ayuso @ 2019-11-06 11:47 UTC (permalink / raw) To: Phil Sutter; +Cc: netfilter-devel On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote: > The shebang is not needed in files to be used with --file parameter. > > Signed-off-by: Phil Sutter <phil@nwl.cc> Right, this is actually handled as a comment right now, not as an indication of what binary the user would like to use. It should be possible to implement the shebang for nft if you think this is useful. Thanks. > --- > doc/nft.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/doc/nft.txt b/doc/nft.txt > index ed2157638032a..c53327e25833d 100644 > --- a/doc/nft.txt > +++ b/doc/nft.txt > @@ -85,8 +85,7 @@ For a full summary of options, run *nft --help*. > > *-f*:: > *--file 'filename'*:: > - Read input from 'filename'. If 'filename' is -, read from stdin. + > - nft scripts must start *#!/usr/sbin/nft -f* > + Read input from 'filename'. If 'filename' is -, read from stdin. > > *-i*:: > *--interactive*:: > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] doc: Drop incorrect requirement for nft configs 2019-11-06 11:47 ` Pablo Neira Ayuso @ 2019-11-06 14:19 ` Phil Sutter 2019-11-06 20:25 ` Pablo Neira Ayuso 0 siblings, 1 reply; 6+ messages in thread From: Phil Sutter @ 2019-11-06 14:19 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel On Wed, Nov 06, 2019 at 12:47:24PM +0100, Pablo Neira Ayuso wrote: > On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote: > > The shebang is not needed in files to be used with --file parameter. > > > > Signed-off-by: Phil Sutter <phil@nwl.cc> > > Right, this is actually handled as a comment right now, not as an > indication of what binary the user would like to use. > > It should be possible to implement the shebang for nft if you think > this is useful. Well, it works already? If I make a config having the shebang executable, I can execute it directly. It's just not needed when passed to 'nft -f'. And in that use-case, I don't see a point in interpreting it, the user already chose which binary to use by calling it. :) Cheers, Phil ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] doc: Drop incorrect requirement for nft configs 2019-11-06 14:19 ` Phil Sutter @ 2019-11-06 20:25 ` Pablo Neira Ayuso 2019-11-06 20:27 ` Pablo Neira Ayuso 0 siblings, 1 reply; 6+ messages in thread From: Pablo Neira Ayuso @ 2019-11-06 20:25 UTC (permalink / raw) To: Phil Sutter, netfilter-devel On Wed, Nov 06, 2019 at 03:19:53PM +0100, Phil Sutter wrote: > On Wed, Nov 06, 2019 at 12:47:24PM +0100, Pablo Neira Ayuso wrote: > > On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote: > > > The shebang is not needed in files to be used with --file parameter. > > > > > > Signed-off-by: Phil Sutter <phil@nwl.cc> > > > > Right, this is actually handled as a comment right now, not as an > > indication of what binary the user would like to use. > > > > It should be possible to implement the shebang for nft if you think > > this is useful. > > Well, it works already? If I make a config having the shebang > executable, I can execute it directly. It's just not needed when passed > to 'nft -f'. And in that use-case, I don't see a point in interpreting > it, the user already chose which binary to use by calling it. :) Indeed, forget this. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] doc: Drop incorrect requirement for nft configs 2019-11-06 20:25 ` Pablo Neira Ayuso @ 2019-11-06 20:27 ` Pablo Neira Ayuso 2019-11-06 20:50 ` Phil Sutter 0 siblings, 1 reply; 6+ messages in thread From: Pablo Neira Ayuso @ 2019-11-06 20:27 UTC (permalink / raw) To: Phil Sutter, netfilter-devel On Wed, Nov 06, 2019 at 09:25:57PM +0100, Pablo Neira Ayuso wrote: > On Wed, Nov 06, 2019 at 03:19:53PM +0100, Phil Sutter wrote: > > On Wed, Nov 06, 2019 at 12:47:24PM +0100, Pablo Neira Ayuso wrote: > > > On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote: > > > > The shebang is not needed in files to be used with --file parameter. > > > > > > > > Signed-off-by: Phil Sutter <phil@nwl.cc> > > > > > > Right, this is actually handled as a comment right now, not as an > > > indication of what binary the user would like to use. > > > > > > It should be possible to implement the shebang for nft if you think > > > this is useful. > > > > Well, it works already? If I make a config having the shebang > > executable, I can execute it directly. It's just not needed when passed > > to 'nft -f'. And in that use-case, I don't see a point in interpreting > > it, the user already chose which binary to use by calling it. :) > > Indeed, forget this. Thanks. BTW, it would be good to remove this from the example files in the tree. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nft PATCH] doc: Drop incorrect requirement for nft configs 2019-11-06 20:27 ` Pablo Neira Ayuso @ 2019-11-06 20:50 ` Phil Sutter 0 siblings, 0 replies; 6+ messages in thread From: Phil Sutter @ 2019-11-06 20:50 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel On Wed, Nov 06, 2019 at 09:27:20PM +0100, Pablo Neira Ayuso wrote: > On Wed, Nov 06, 2019 at 09:25:57PM +0100, Pablo Neira Ayuso wrote: > > On Wed, Nov 06, 2019 at 03:19:53PM +0100, Phil Sutter wrote: > > > On Wed, Nov 06, 2019 at 12:47:24PM +0100, Pablo Neira Ayuso wrote: > > > > On Tue, Nov 05, 2019 at 02:14:39PM +0100, Phil Sutter wrote: > > > > > The shebang is not needed in files to be used with --file parameter. > > > > > > > > > > Signed-off-by: Phil Sutter <phil@nwl.cc> > > > > > > > > Right, this is actually handled as a comment right now, not as an > > > > indication of what binary the user would like to use. > > > > > > > > It should be possible to implement the shebang for nft if you think > > > > this is useful. > > > > > > Well, it works already? If I make a config having the shebang > > > executable, I can execute it directly. It's just not needed when passed > > > to 'nft -f'. And in that use-case, I don't see a point in interpreting > > > it, the user already chose which binary to use by calling it. :) > > > > Indeed, forget this. Thanks. > > BTW, it would be good to remove this from the example files in the tree. I'll send a patch, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-06 20:50 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-05 13:14 [nft PATCH] doc: Drop incorrect requirement for nft configs Phil Sutter 2019-11-06 11:47 ` Pablo Neira Ayuso 2019-11-06 14:19 ` Phil Sutter 2019-11-06 20:25 ` Pablo Neira Ayuso 2019-11-06 20:27 ` Pablo Neira Ayuso 2019-11-06 20:50 ` Phil Sutter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).