From: Jan-Martin Raemer <raemer@zit-rlp.de>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378)
Date: Thu, 7 Nov 2019 09:17:10 +0100 [thread overview]
Message-ID: <20191107081710.GC5020@laptop-jmr.hs-koblenz.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
Hi,
as reported in https://bugzilla.netfilter.org/show_bug.cgi?id=1378,
conntrackd refuses to start with a vaild IPv6_Destination_Address,
reporting "inet_pton(): IPv6 unsupported" due to a forgotten handling of
err>0 (i.e. success). This patch fixes the issue:
Signed-off-by: Jan-Martin Raemer <raemer@zit-rlp.de>
diff --git a/src/read_config_yy.y b/src/read_config_yy.y
index a4aa7f5..31109c4 100644
--- a/src/read_config_yy.y
+++ b/src/read_config_yy.y
@@ -467,7 +467,7 @@ udp_option : T_IPV6_DEST_ADDR T_IP
dlog(LOG_WARNING, "%s is not a valid IPv6 address", $2);
free($2);
break;
- } else {
+ } else if (err < 0) {
dlog(LOG_ERR, "inet_pton(): IPv6 unsupported!");
exit(EXIT_FAILURE);
}
Best regards,
Jan-Martin
--
Dr. Jan-Martin Rämer
Systemtechnik
Zentrum für Hochschul-IT Rheinland-Pfalz
Moselweißer Straße 4, 56073 Koblenz
Telefon +49(0)261 9528-906
raemer@zit-rlp.de
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6695 bytes --]
next reply other threads:[~2019-11-07 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 8:17 Jan-Martin Raemer [this message]
2019-11-07 9:37 ` [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378) Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107081710.GC5020@laptop-jmr.hs-koblenz.de \
--to=raemer@zit-rlp.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).