Netfilter-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378)
@ 2019-11-07  8:17 Jan-Martin Raemer
  2019-11-07  9:37 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Jan-Martin Raemer @ 2019-11-07  8:17 UTC (permalink / raw)
  To: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi,

as reported in https://bugzilla.netfilter.org/show_bug.cgi?id=1378,
conntrackd refuses to start with a vaild IPv6_Destination_Address,
reporting "inet_pton(): IPv6 unsupported" due to a forgotten handling of
err>0 (i.e. success). This patch fixes the issue:

Signed-off-by: Jan-Martin Raemer <raemer@zit-rlp.de>
diff --git a/src/read_config_yy.y b/src/read_config_yy.y
index a4aa7f5..31109c4 100644
--- a/src/read_config_yy.y
+++ b/src/read_config_yy.y
@@ -467,7 +467,7 @@ udp_option : T_IPV6_DEST_ADDR T_IP
                dlog(LOG_WARNING, "%s is not a valid IPv6 address", $2);
                free($2);
                break;
-       } else {
+       } else if (err < 0) {
                dlog(LOG_ERR, "inet_pton(): IPv6 unsupported!");
                exit(EXIT_FAILURE);
        }

Best regards,
Jan-Martin

-- 
Dr. Jan-Martin Rämer
Systemtechnik
Zentrum für Hochschul-IT Rheinland-Pfalz
Moselweißer Straße 4, 56073 Koblenz
Telefon +49(0)261 9528-906
raemer@zit-rlp.de

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6695 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378)
  2019-11-07  8:17 [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378) Jan-Martin Raemer
@ 2019-11-07  9:37 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2019-11-07  9:37 UTC (permalink / raw)
  To: Jan-Martin Raemer; +Cc: netfilter-devel

On Thu, Nov 07, 2019 at 09:17:10AM +0100, Jan-Martin Raemer wrote:
> Hi,
> 
> as reported in https://bugzilla.netfilter.org/show_bug.cgi?id=1378,
> conntrackd refuses to start with a vaild IPv6_Destination_Address,
> reporting "inet_pton(): IPv6 unsupported" due to a forgotten handling of
> err>0 (i.e. success). This patch fixes the issue:

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07  8:17 [PATCH] conntrackd UDP IPv6 destination address not usable (Bug 1378) Jan-Martin Raemer
2019-11-07  9:37 ` Pablo Neira Ayuso

Netfilter-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \
		netfilter-devel@vger.kernel.org
	public-inbox-index netfilter-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git