From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C0BC432C0 for ; Mon, 18 Nov 2019 18:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92A21222BF for ; Mon, 18 Nov 2019 18:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfKRSaT (ORCPT ); Mon, 18 Nov 2019 13:30:19 -0500 Received: from correo.us.es ([193.147.175.20]:46736 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbfKRSaS (ORCPT ); Mon, 18 Nov 2019 13:30:18 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id EC3DB1C41CB for ; Mon, 18 Nov 2019 19:30:13 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id DECE2B7FF6 for ; Mon, 18 Nov 2019 19:30:13 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id D45A9B7FF2; Mon, 18 Nov 2019 19:30:13 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9871DDA4CA; Mon, 18 Nov 2019 19:30:11 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 18 Nov 2019 19:30:11 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 73C5B42EE38E; Mon, 18 Nov 2019 19:30:11 +0100 (CET) Date: Mon, 18 Nov 2019 19:30:13 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Christian =?iso-8859-1?Q?G=F6ttsche?= Cc: netfilter-devel@vger.kernel.org Subject: Re: nftables: secmark support Message-ID: <20191118183013.zaaupujid7pnmp33@salvia> References: <20191022173411.zh3o2wnoqxpjhjkq@salvia> <20191118181849.k4tb5rnmcuzigbaw@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191118181849.k4tb5rnmcuzigbaw@salvia> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Nov 18, 2019 at 07:18:49PM +0100, Pablo Neira Ayuso wrote: > Hi Christian, > > On Mon, Nov 18, 2019 at 05:44:07PM +0100, Christian Göttsche wrote: > > Am Mo., 28. Okt. 2019 um 15:27 Uhr schrieb Christian Göttsche > > : > > > > This is what your patch [6] does, right? If you don't mind to rebase > > > > it I can have a look if I can propose you something else than this new > > > > keyword. > > > > > > Attached at the end (base on 707ad229d48f2ba7920541527b755b155ddedcda) > > > > friendly ping; any progress? > > > > rebased against 4a382ec54a8c09df1a625ddc7d32fc06257c596d at > > https://paste.debian.net/1116802/ > > Thanks for following up on this. A few comments on your patch: > > 1) I would replace secmark_raw by secmark instead. I think we should > hide this assymmetry to the user. I would suggest you also extend > the evaluation phase, ie. expr_evaluate_meta() and expr_evaluate_ct() > to bail out in case the user tries to match on the raw packet / ct > secmark ID. IIRC, the only usecase for this raw ID is to save and > to restore the secmark from/to the packet to/from the conntrack > object. > > And a few minor issues: > > 2) Please remove meta_key_unqualified chunk. > > meta_key_unqualified SET stmt_expr I mean, this update (moving the location of this rule) is not necessary, right? Thanks. > 3) Remove the reset command chunk too: > > --- a/src/rule.c > +++ b/src/rule.c > @@ -2539,6 +2539,12 @@ static int do_command_reset(struct netlink_ctx > *ctx, struct cmd *cmd) > case CMD_OBJ_QUOTA: > type = NFT_OBJECT_QUOTA; > break; > + case CMD_OBJ_SECMARKS: > + dump = true; > + /* fall through */ > + case CMD_OBJ_SECMARK: > + type = NFT_OBJECT_SECMARK; > + break; > default: > BUG("invalid command object type %u\n", cmd->obj); > } > > Thanks.