From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: Documentation question
Date: Thu, 21 Nov 2019 16:33:34 +1100 [thread overview]
Message-ID: <20191121053334.GB12786@dimstar.local.net> (raw)
In-Reply-To: <20191120232617.GH20235@breakpoint.cc>
On Thu, Nov 21, 2019 at 12:26:17AM +0100, Florian Westphal wrote:
> Duncan Roe <duncan_roe@optusnet.com.au> wrote:
> > Deprecated nfq_set_queue_flags documents flag NFQA_CFG_F_FAIL_OPEN for kernel to
> > accept packets if the kernel queue gets full.
> >
> > Does this still work with libmnl?
>
> Yes.
> > I'm thinking we need a new "Library Setup
> > [CURRENT]" section to document available flags (including e.g. NFQA_CFG_F_GSO
> > that examples/nf-queue.c uses).
>
> Makes sense, thanks.
>
> > Maybe we need Attribute helper functions as well? (documentation *and* new
> > code).
>
> If you think it makes it easier, sure, why not.
> But it would be something like this:
>
> void nfq_nlmsg_cfg_put_flags(struct nlmsghdr *nlh, uint32_t flags)
> {
> mnl_attr_put_u32(nlh, NFQA_CFG_FLAGS, htonl(flags));
> mnl_attr_put_u32(nlh, NFQA_CFG_MASK, htonl(flags));
> }
>
> I'm not sure that warrants a library helper.
Many of the existing helper functions are 2-liners, some even 1 line. These
little functions often have more lines of doxygen documentation than of code.
So I think the extra helpers would fit in fine.
Cheers ... Duncan.
next prev parent reply other threads:[~2019-11-21 5:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 23:09 Documentation question Duncan Roe
2019-11-20 23:26 ` Florian Westphal
2019-11-21 5:33 ` Duncan Roe [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-04 23:45 Duncan Roe
2021-07-05 8:56 ` Pablo Neira Ayuso
2021-07-05 13:13 ` Duncan Roe
2021-07-05 14:42 ` Pablo Neira Ayuso
2019-12-15 2:02 Duncan Roe
2019-12-20 0:29 ` Pablo Neira Ayuso
2019-12-21 10:43 ` Duncan Roe
2019-12-22 2:23 ` Duncan Roe
2019-10-30 9:07 Duncan Roe
2019-10-30 9:15 ` Pablo Neira Ayuso
2019-10-30 9:38 ` Duncan Roe
2019-10-30 9:47 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121053334.GB12786@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).