From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33865C432C3 for ; Mon, 2 Dec 2019 18:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CC0C2073C for ; Mon, 2 Dec 2019 18:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbfLBS6J (ORCPT ); Mon, 2 Dec 2019 13:58:09 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:40288 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727464AbfLBS6J (ORCPT ); Mon, 2 Dec 2019 13:58:09 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ibqtc-0007yK-3Z; Mon, 02 Dec 2019 19:58:08 +0100 Date: Mon, 2 Dec 2019 19:58:08 +0100 From: Florian Westphal To: Marco Oliverio Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, fw@strlen.de, rocco.folino@tanaza.com Subject: Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst Message-ID: <20191202185808.GS795@breakpoint.cc> References: <20191202185430.31367-1-marco.oliverio@tanaza.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202185430.31367-1-marco.oliverio@tanaza.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Marco Oliverio wrote: > Bridge packets that are forwarded have skb->dst == NULL and get > dropped by the check introduced by > b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force > return true when dst is refcounted). Acked-by: Florian Westphal