From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009C3C432C0 for ; Mon, 2 Dec 2019 22:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFAAF2073C for ; Mon, 2 Dec 2019 22:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbfLBWYc (ORCPT ); Mon, 2 Dec 2019 17:24:32 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:54624 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLBWYc (ORCPT ); Mon, 2 Dec 2019 17:24:32 -0500 Received: from localhost ([::1]:39482 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1ibu7L-0000F7-Gk; Mon, 02 Dec 2019 23:24:31 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: [libnftnl PATCH 2/4] chain: Fix memleak in error path of nftnl_chain_parse_devs() Date: Mon, 2 Dec 2019 23:23:59 +0100 Message-Id: <20191202222401.867-3-phil@nwl.cc> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191202222401.867-1-phil@nwl.cc> References: <20191202222401.867-1-phil@nwl.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org In error case, dev_array is not freed when it should. Fixes: e3ac19b5ec162 ("chain: multi-device support") Signed-off-by: Phil Sutter --- src/chain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/chain.c b/src/chain.c index d4050d28e77d0..9cc8735a4936f 100644 --- a/src/chain.c +++ b/src/chain.c @@ -636,6 +636,7 @@ static int nftnl_chain_parse_devs(struct nlattr *nest, struct nftnl_chain *c) err: while (len--) xfree(dev_array[len]); + xfree(dev_array); return -1; } -- 2.24.0