netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] selftests: netfilter: use randomized netns names
Date: Thu, 5 Dec 2019 00:14:04 +0100	[thread overview]
Message-ID: <20191204231404.GA14469@orbyte.nwl.cc> (raw)
In-Reply-To: <20191202173540.12230-1-fw@strlen.de>

Hi,

On Mon, Dec 02, 2019 at 06:35:40PM +0100, Florian Westphal wrote:
[...]
> @@ -532,32 +547,32 @@ EOF
>  	# ns1 should not have seen packets from ns2, due to masquerade
>  	expect="packets 0 bytes 0"
>  	for dir in "in" "out" ; do
> -		cnt=$(ip netns exec ns1 nft list counter inet filter ns2${dir} | grep -q "$expect")
> +		cnt=$(ip netns exec "$ns1" nft list counter inet filter ns2${dir} | grep -q "$expect")
>  		if [ $? -ne 0 ]; then
> -			bad_counter ns1 ns0$dir "$expect"
> +			bad_counter "$ns1" ns0$dir "$expect" "test_masquerade 5"
>  			lret=1
>  		fi
>  
> -		cnt=$(ip netns exec ns1 nft list counter inet filter ns2${dir} | grep -q "$expect")
> +		cnt=$(ip netns exec "$ns0" nft list counter inet filter ns1${dir} | grep -q "$expect")

This is confusing. You're fixing a bug and it is correct?

>  		if [ $? -ne 0 ]; then
> -			bad_counter ns2 ns1$dir "$expect"
> +			bad_counter "$ns0" ns1$dir "$expect" "test_masquerade 6"

And here as well?

[...]
> @@ -708,28 +723,28 @@ EOF
>  	# ns0 should have seen packets from ns2, due to masquerade
>  	expect="packets 1 bytes 84"
>  	for dir in "in" "out" ; do
> -		cnt=$(ip netns exec ns0 nft list counter inet filter ns2${dir} | grep -q "$expect")
> +		cnt=$(ip netns exec "$ns0" nft list counter inet filter ns2${dir} | grep -q "$expect")
>  		if [ $? -ne 0 ]; then
> -			bad_counter ns1 ns0$dir "$expect"
> +			bad_counter "$ns0" ns0$dir "$expect" "test_redirect 4"

This is actually a bugfix, right?

Assuming the above non-trivial cases are correct:

Acked-by: Phil Sutter <phil@nwl.cc>

Cheers, Phil

  reply	other threads:[~2019-12-04 23:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 17:35 [PATCH nf] selftests: netfilter: use randomized netns names Florian Westphal
2019-12-04 23:14 ` Phil Sutter [this message]
2019-12-04 23:20   ` Florian Westphal
2019-12-06  9:15 ` Stefano Brivio
2019-12-07 18:52 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204231404.GA14469@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).