From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@ucloud.cn
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf v2 1/3] netfilter: nf_flow_table_offload: fix dst_neigh lookup
Date: Fri, 20 Dec 2019 02:18:59 +0100 [thread overview]
Message-ID: <20191220011859.2hbzrqpziyj72ylt@salvia> (raw)
In-Reply-To: <20191219221816.rywke7de6izqrere@salvia>
On Thu, Dec 19, 2019 at 11:18:16PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Dec 17, 2019 at 04:52:45PM +0800, wenxu@ucloud.cn wrote:
> > From: wenxu <wenxu@ucloud.cn>
> >
> > Get the dst_neigh through dst_ip, The dst_ip should get
> > through peer tuple.src_v4 fix for dnat case.
>
> Please, revamp patch description:
>
> netfilter: nf_flow_table_offload: fix incorrect ethernet dst address
>
> Proposed description:
>
> original: A -> FW
> reply: B -> A
This part above is not correct, actually FW should be B instead.
> Traffic going in original direction uses address B as
> destination. Traffic going in reply direction uses address A
> as destination.
This should be instead:
Ethernet destination for original traffic takes the source ethernet address
in the reply direction. For reply traffic, this takes the source
ethernet address of the original direction.
Hope this helps to clarify.
next prev parent reply other threads:[~2019-12-20 1:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 8:52 [PATCH nf v2 0/3] netfilter: nf_flow_table_offload: something fixes wenxu
2019-12-17 8:52 ` [PATCH nf v2 1/3] netfilter: nf_flow_table_offload: fix dst_neigh lookup wenxu
2019-12-19 22:18 ` Pablo Neira Ayuso
2019-12-20 1:18 ` Pablo Neira Ayuso [this message]
2019-12-20 3:53 ` wenxu
2019-12-20 9:13 ` Pablo Neira Ayuso
2019-12-20 9:19 ` wenxu
2019-12-20 10:31 ` Pablo Neira Ayuso
2019-12-20 14:15 ` wenxu
2019-12-17 8:52 ` [PATCH nf v2 2/3] netfilter: nf_flow_table_offload: check the status of dst_neigh wenxu
2019-12-17 8:52 ` [PATCH nf v2 3/3] netfilter: nf_flow_table_offload: fix the nat port mangle wenxu
2019-12-19 23:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220011859.2hbzrqpziyj72ylt@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).