From: Duncan Roe <duncan_roe@optusnet.com.au>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH libnetfilter_queue] src: checksum.c: remove redundant 0xFFFF mask of uint16_t
Date: Tue, 31 Dec 2019 12:06:07 +1100 [thread overview]
Message-ID: <20191231010607.14313-1-duncan_roe@optusnet.com.au> (raw)
In-Reply-To: <20191230113345.olr3yifqqmytv3ce@salvia>
Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/src/extra/checksum.c b/src/extra/checksum.c
index 8b23997..a650b64 100644
--- a/src/extra/checksum.c
+++ b/src/extra/checksum.c
@@ -70,10 +70,10 @@ uint16_t nfq_checksum_tcpudp_ipv6(struct ip6_hdr *ip6h, void *transport_hdr,
int i;
for (i=0; i<8; i++) {
- sum += (ip6h->ip6_src.s6_addr16[i]) & 0xFFFF;
+ sum += (ip6h->ip6_src.s6_addr16[i]);
}
for (i=0; i<8; i++) {
- sum += (ip6h->ip6_dst.s6_addr16[i]) & 0xFFFF;
+ sum += (ip6h->ip6_dst.s6_addr16[i]);
}
sum += htons(protonum);
sum += htons(len);
--
2.14.5
next prev parent reply other threads:[~2019-12-31 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 5:53 [PATCH libnetfilter_queue 0/2] Add mangle functions for IPv6, IPv6/TCP and IPv6/UDP Duncan Roe
2019-12-20 5:53 ` [PATCH libnetfilter_queue 1/2] src: more IPv6 checksum fixes Duncan Roe
2019-12-30 11:33 ` Pablo Neira Ayuso
2019-12-31 1:06 ` Duncan Roe [this message]
2020-01-03 12:25 ` [PATCH libnetfilter_queue] src: checksum.c: remove redundant 0xFFFF mask of uint16_t Florian Westphal
2019-12-20 5:53 ` [PATCH libnetfilter_queue 2/2] src: add mangle functions for IPv6, IPv6/TCP and IPv6/UDP Duncan Roe
2019-12-30 11:33 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231010607.14313-1-duncan_roe@optusnet.com.au \
--to=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).