From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: better error notice when interval flag is not set on
Date: Fri, 10 Jan 2020 14:07:25 +0100 [thread overview]
Message-ID: <20200110130725.GQ20229@orbyte.nwl.cc> (raw)
In-Reply-To: <20200110105546.241847-1-pablo@netfilter.org>
On Fri, Jan 10, 2020 at 11:55:46AM +0100, Pablo Neira Ayuso wrote:
> Users get confused with the existing error notice, let's try a different one:
>
> # nft add element x y { 1.1.1.0/24 }
> Error: You must add 'flags interval' to your set declaration if you want to add prefix elements
> add element x y { 1.1.1.0/24 }
> ^^^^^^^^^^
Not sure why "missing inverval flag on declaration" is more confusing
than "you must add 'flags interval' to ...", but maybe I'm just too much
into the topic to notice the difference. :)
> Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1395
Unrelated? Did you pick the wrong ticket ID?
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Except for nfbz link:
Acked-by: Phil Sutter <phil@nwl.cc>
prev parent reply other threads:[~2020-01-10 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 10:55 [PATCH nft] evaluate: better error notice when interval flag is not set on Pablo Neira Ayuso
2020-01-10 13:07 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110130725.GQ20229@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).