From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] monitor: Fix output for ranges in anonymous sets
Date: Mon, 13 Jan 2020 16:23:07 +0100 [thread overview]
Message-ID: <20200113152307.hgfvycka4666gqis@salvia> (raw)
In-Reply-To: <20200113135911.22740-1-phil@nwl.cc>
On Mon, Jan 13, 2020 at 02:59:11PM +0100, Phil Sutter wrote:
> Previous fix for named interval sets was simply wrong: Instead of
> limiting decomposing to anonymous interval sets, it effectively disabled
> it entirely.
>
> Since code needs to check for both interval and anonymous bits
> separately, introduce set_is_interval() helper to keep the code
> readable.
>
> Also extend test case to assert ranges in anonymous sets are correctly
> printed by echo or monitor modes. Without this fix, range boundaries are
> printed as individual set elements.
>
> Fixes: 5d57fa3e99bb9 ("monitor: Do not decompose non-anonymous sets")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2020-01-13 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:59 [nft PATCH] monitor: Fix output for ranges in anonymous sets Phil Sutter
2020-01-13 15:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113152307.hgfvycka4666gqis@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).