From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26034C33CB1 for ; Tue, 14 Jan 2020 13:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03D6E206D7 for ; Tue, 14 Jan 2020 13:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbgANNjw (ORCPT ); Tue, 14 Jan 2020 08:39:52 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:50592 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgANNjw (ORCPT ); Tue, 14 Jan 2020 08:39:52 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1irMQB-0005m9-AZ; Tue, 14 Jan 2020 14:39:51 +0100 Date: Tue, 14 Jan 2020 14:39:51 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] xfrm: spi is big endian Message-ID: <20200114133951.GO795@breakpoint.cc> References: <20200114124015.31064-1-fw@strlen.de> <20200114132701.ybocb7vhgwd2yepx@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114132701.ybocb7vhgwd2yepx@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > On Tue, Jan 14, 2020 at 01:40:15PM +0100, Florian Westphal wrote: > > the kernel stores spi in a __be32, so fix up the byteorder annotation > > accordingly. > > > > Signed-off-by: Florian Westphal > > Acked-by: Pablo Neira Ayuso > > Please, update tests/py too, I guess that will spew a warning after > this update? Yup, pushed with amended test case, thanks for the reminder.