From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 1/2] tests: shell: Search diff tool once and for all
Date: Thu, 16 Jan 2020 14:17:27 +0100 [thread overview]
Message-ID: <20200116131727.pynbcqhtnzkksrux@salvia> (raw)
In-Reply-To: <20200114164630.2492-1-phil@nwl.cc>
On Tue, Jan 14, 2020 at 05:46:29PM +0100, Phil Sutter wrote:
> Instead of calling 'which diff' over and over again, just detect the
> tool's presence in run-tests.sh and pass $DIFF to each testcase just
> like with nft binary.
>
> Fall back to using 'true' command to avoid the need for any conditional
> calling in test cases.
>
> While being at it, unify potential diff calls so that a string
> comparison in shell happens irrespective of diff presence.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2020-01-16 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:46 [nft PATCH 1/2] tests: shell: Search diff tool once and for all Phil Sutter
2020-01-14 16:46 ` [nft PATCH 2/2] cache: Fix for doubled output after reset command Phil Sutter
2020-01-16 13:17 ` Pablo Neira Ayuso
2020-01-16 13:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116131727.pynbcqhtnzkksrux@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).