From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFBAC32771 for ; Fri, 24 Jan 2020 18:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D01502072C for ; Fri, 24 Jan 2020 18:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388649AbgAXStW (ORCPT ); Fri, 24 Jan 2020 13:49:22 -0500 Received: from correo.us.es ([193.147.175.20]:40620 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387843AbgAXStW (ORCPT ); Fri, 24 Jan 2020 13:49:22 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9356EBAEF2 for ; Fri, 24 Jan 2020 19:49:19 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 85D93DA716 for ; Fri, 24 Jan 2020 19:49:19 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 79A1EDA710; Fri, 24 Jan 2020 19:49:19 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5E3B8DA705; Fri, 24 Jan 2020 19:49:17 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 24 Jan 2020 19:49:17 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 407C842EE38E; Fri, 24 Jan 2020 19:49:17 +0100 (CET) Date: Fri, 24 Jan 2020 19:49:16 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jiri Wiesner Cc: netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Michal Kubecek Subject: Re: [PATCH nf] netfilter: conntrack: sctp: use distinct states for new SCTP connections Message-ID: <20200124184916.axf6oy6jcduyhcfa@salvia> References: <20200118121050.GA22909@incl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200118121050.GA22909@incl> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sat, Jan 18, 2020 at 01:10:50PM +0100, Jiri Wiesner wrote: > The netlink notifications triggered by the INIT and INIT_ACK chunks > for a tracked SCTP association do not include protocol information > for the corresponding connection - SCTP state and verification tags > for the original and reply direction are missing. Since the connection > tracking implementation allows user space programs to receive > notifications about a connection and then create a new connection > based on the values received in a notification, it makes sense that > INIT and INIT_ACK notifications should contain the SCTP state > and verification tags available at the time when a notification > is sent. The missing verification tags cause a newly created > netfilter connection to fail to verify the tags of SCTP packets > when this connection has been created from the values previously > received in an INIT or INIT_ACK notification. > > A PROTOINFO event is cached in sctp_packet() when the state > of a connection changes. The CLOSED and COOKIE_WAIT state will > be used for connections that have seen an INIT and INIT_ACK chunk, > respectively. The distinct states will cause a connection state > change in sctp_packet(). Applied, thanks for explaining.