From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94060C33C9E for ; Tue, 28 Jan 2020 11:24:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E57424681 for ; Tue, 28 Jan 2020 11:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725948AbgA1LYb (ORCPT ); Tue, 28 Jan 2020 06:24:31 -0500 Received: from correo.us.es ([193.147.175.20]:34492 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgA1LYb (ORCPT ); Tue, 28 Jan 2020 06:24:31 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id CE26FE34F6 for ; Tue, 28 Jan 2020 12:24:29 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BF3A0DA718 for ; Tue, 28 Jan 2020 12:24:29 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id B4E7FDA715; Tue, 28 Jan 2020 12:24:29 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A158ADA714; Tue, 28 Jan 2020 12:24:27 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 28 Jan 2020 12:24:27 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 7B0D14301DE1; Tue, 28 Jan 2020 12:24:27 +0100 (CET) Date: Tue, 28 Jan 2020 12:24:26 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [nft PATCH 2/4] segtree: Drop dead code in ei_insert() Message-ID: <20200128112426.qn2qicqmyorcxitr@salvia> References: <20200123143049.13888-1-phil@nwl.cc> <20200123143049.13888-3-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123143049.13888-3-phil@nwl.cc> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jan 23, 2020 at 03:30:47PM +0100, Phil Sutter wrote: > Caller sorts new items to be added, therefore when checking for overlaps > the current range can only overlap on lower end. Drop the check for > upper end overlap. > > Signed-off-by: Phil Sutter Acked-by: Pablo Neira Ayuso The iteration over the sorted array guarantees there cannot be an interval.