From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: netfilter-devel@vger.kernel.org,
"Florian Westphal" <fw@strlen.de>,
"Kadlecsik József" <kadlec@blackhole.kfki.hu>,
"Eric Garver" <eric@garver.life>, "Phil Sutter" <phil@nwl.cc>
Subject: Re: [PATCH nft v4 2/4] src: Add support for NFTNL_SET_DESC_CONCAT
Date: Fri, 7 Feb 2020 11:25:36 +0100 [thread overview]
Message-ID: <20200207102536.z24533bex6n6qhsg@salvia> (raw)
In-Reply-To: <1edea54ac5bc93158c52152214a9e0d44a0aa111.1580342294.git.sbrivio@redhat.com>
On Thu, Jan 30, 2020 at 01:16:56AM +0100, Stefano Brivio wrote:
> To support arbitrary range concatenations, the kernel needs to know
> how long each field in the concatenation is. The new libnftnl
> NFTNL_SET_DESC_CONCAT set attribute describes this as an array of
> lengths, in bytes, of concatenated fields.
>
> While evaluating concatenated expressions, export the datatype size
> into the new field_len array, and hand the data over via libnftnl.
>
> Similarly, when data is passed back from libnftnl, parse it into
> the set description.
>
> When set data is cloned, we now need to copy the additional fields
> in set_clone(), too.
>
> This change depends on the libnftnl patch with title:
> set: Add support for NFTA_SET_DESC_CONCAT attributes
Also applied, thanks.
next prev parent reply other threads:[~2020-02-07 10:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 0:16 [PATCH nft v4 0/4] Introduce support for concatenated ranges Stefano Brivio
2020-01-30 0:16 ` [PATCH nft v4 1/4] include: resync nf_tables.h cache copy Stefano Brivio
2020-02-07 10:25 ` Pablo Neira Ayuso
2020-01-30 0:16 ` [PATCH nft v4 2/4] src: Add support for NFTNL_SET_DESC_CONCAT Stefano Brivio
2020-02-07 10:25 ` Pablo Neira Ayuso [this message]
2020-01-30 0:16 ` [PATCH nft v4 3/4] src: Add support for concatenated set ranges Stefano Brivio
2020-02-07 10:33 ` Pablo Neira Ayuso
2020-02-10 15:08 ` Stefano Brivio
2020-02-07 11:18 ` Pablo Neira Ayuso
2020-02-10 15:09 ` Stefano Brivio
2020-01-30 0:16 ` [PATCH nft v4 4/4] tests: Introduce test for set with concatenated ranges Stefano Brivio
2020-02-06 10:14 ` Phil Sutter
2020-02-07 10:34 ` Pablo Neira Ayuso
2020-02-10 15:08 ` Stefano Brivio
2020-02-10 15:51 ` Phil Sutter
2020-02-10 16:04 ` Florian Westphal
2020-02-10 16:16 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207102536.z24533bex6n6qhsg@salvia \
--to=pablo@netfilter.org \
--cc=eric@garver.life \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).