From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58067C352A4 for ; Mon, 10 Feb 2020 23:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32A3720715 for ; Mon, 10 Feb 2020 23:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgBJXdA (ORCPT ); Mon, 10 Feb 2020 18:33:00 -0500 Received: from correo.us.es ([193.147.175.20]:40182 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727452AbgBJXdA (ORCPT ); Mon, 10 Feb 2020 18:33:00 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 54EF4EB903 for ; Tue, 11 Feb 2020 00:33:00 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 495C6DA703 for ; Tue, 11 Feb 2020 00:33:00 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 3EFD3DA707; Tue, 11 Feb 2020 00:33:00 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 4FDD1DA70E; Tue, 11 Feb 2020 00:32:58 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 11 Feb 2020 00:32:58 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 2C54B4251481; Tue, 11 Feb 2020 00:32:58 +0100 (CET) Date: Tue, 11 Feb 2020 00:32:56 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Laurent Fasnacht Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft include v2 4/7] scanner: remove parser_state->indescs static array Message-ID: <20200210233256.bis2igtwje77vimm@salvia> References: <20200210101709.9182-1-fasnacht@protonmail.ch> <20200210101709.9182-5-fasnacht@protonmail.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200210101709.9182-5-fasnacht@protonmail.ch> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Feb 10, 2020 at 10:17:24AM +0000, Laurent Fasnacht wrote: > This static array is redundant wth the indesc_list structure, but > is less flexible. Skipping this patch and taking 5/7, I get a crash. Sorry, I'm trying to understand if there is an easy fix for this, without simplifying things. I mean, first fix things, then move on and improve everything. The removal of the array stack looks like mandatory dependency to fix this? Please, help me understand. Thanks.