From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH v2] xtables-translate: Fix for interface name corner-cases
Date: Tue, 11 Feb 2020 09:52:40 +0100 [thread overview]
Message-ID: <20200211085240.ivexmgfusvziqbex@salvia> (raw)
In-Reply-To: <20200210124828.32400-1-phil@nwl.cc>
On Mon, Feb 10, 2020 at 01:48:28PM +0100, Phil Sutter wrote:
> There are two special situations xlate_ifname() didn't cover for:
>
> * Interface name containing '*': This went unchanged, creating a command
> nft wouldn't accept. Instead translate into '\*' which doesn't change
> semantics.
>
> * Interface name being '+': Can't translate into nft wildcard character
> as nft doesn't accept asterisk-only interface names. Instead decide
> what to do based on 'invert' value: Skip match creation if false,
> match against an invalid interface name if true.
>
> Also add a test to make sure future changes to this behaviour are
> noticed.
Phil, this is fine. Thanks.
prev parent reply other threads:[~2020-02-11 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 12:48 [iptables PATCH v2] xtables-translate: Fix for interface name corner-cases Phil Sutter
2020-02-11 8:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211085240.ivexmgfusvziqbex@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).