From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] src: Fix nftnl_assert() on data_len
Date: Wed, 19 Feb 2020 10:32:10 +0100 [thread overview]
Message-ID: <20200219093210.qihfks66qvfak5th@salvia> (raw)
In-Reply-To: <20200218230239.GE20005@orbyte.nwl.cc>
On Wed, Feb 19, 2020 at 12:02:39AM +0100, Phil Sutter wrote:
> Hi Pablo,
>
> On Tue, Feb 18, 2020 at 10:06:11PM +0100, Pablo Neira Ayuso wrote:
> [...]
> > If I apply the patch that I'm attaching, then I use the wrong datatype
> > helper:
> >
> > nftnl_flowtable_get_u32(nlo, NFTNL_FLOWTABLE_DEVICES);
> >
> > And I can see:
> >
> > libnftnl: attribute 6 assertion failed in flowtable.c:274
>
> Yes, that was what I meant with alternative (simpler) approach. Should I
> submit this change formally or do you want to do it?
Please submit and push it out, thanks.
prev parent reply other threads:[~2020-02-19 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:24 [libnftnl PATCH] src: Fix nftnl_assert() on data_len Phil Sutter
2020-02-14 17:32 ` Pablo Neira Ayuso
2020-02-14 17:34 ` Phil Sutter
2020-02-14 17:42 ` Pablo Neira Ayuso
2020-02-15 0:43 ` Phil Sutter
2020-02-15 13:17 ` Pablo Neira Ayuso
2020-02-15 22:58 ` Phil Sutter
2020-02-18 13:42 ` Pablo Neira Ayuso
2020-02-18 18:18 ` Phil Sutter
2020-02-18 21:06 ` Pablo Neira Ayuso
2020-02-18 23:02 ` Phil Sutter
2020-02-19 9:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219093210.qihfks66qvfak5th@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).