[PATCH nf-next v2] netfilter: nf_flow_table_offload: set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY

[PATCH nf-next v2] netfilter: nf_flow_table_offload: set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY

[wenxu]

From: wenxu <wenxu@ucloud.cn>

Set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY to
follow the driver behavior.

Signed-off-by: wenxu <wenxu@ucloud.cn>
---
 net/netfilter/nf_flow_table_offload.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c
index a68136a..88d2ac5 100644
--- a/net/netfilter/nf_flow_table_offload.c
+++ b/net/netfilter/nf_flow_table_offload.c
@@ -165,8 +165,12 @@ static void flow_offload_mangle(struct flow_action_entry *entry,
 flow_action_entry_next(struct nf_flow_rule *flow_rule)
 {
 	int i = flow_rule->rule->action.num_entries++;
+	struct flow_action_entry *entry;
+
+	entry = &flow_rule->rule->action.entries[i];
+	entry->hw_stats_type = FLOW_ACTION_HW_STATS_ANY;
 
-	return &flow_rule->rule->action.entries[i];
+	return entry;
 }
 
 static int flow_offload_eth_src(struct net *net,
-- 
1.8.3.1

Re: [PATCH nf-next v2] netfilter: nf_flow_table_offload: set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY

[Pablo Neira Ayuso]

On Fri, Mar 20, 2020 at 08:57:09PM +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> Set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY to
> follow the driver behavior.

Now you have to explain me how you are going to use this.

There is no support for packet/bytes stats right now.

Thank you.

Re: [PATCH nf-next v2] netfilter: nf_flow_table_offload: set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY

[wenxu]

在 2020/3/20 21:04, Pablo Neira Ayuso 写道:
> On Fri, Mar 20, 2020 at 08:57:09PM +0800, wenxu@ucloud.cn wrote:
>> From: wenxu <wenxu@ucloud.cn>
>>
>> Set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY to
>> follow the driver behavior.
> Now you have to explain me how you are going to use this.
>
> There is no support for packet/bytes stats right now.
>
> Thank you.

The FLOW_ACTION_HW_STATS_ANY flags is the default behavior and

can avoid the failure of flow inserting. We don't nedd to use this.

>

Re: [PATCH nf-next v2] netfilter: nf_flow_table_offload: set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY

[Pablo Neira Ayuso]

On Fri, Mar 20, 2020 at 09:55:35PM +0800, wenxu wrote:
> 
> 在 2020/3/20 21:04, Pablo Neira Ayuso 写道:
> > On Fri, Mar 20, 2020 at 08:57:09PM +0800, wenxu@ucloud.cn wrote:
> > > From: wenxu <wenxu@ucloud.cn>
> > > 
> > > Set hw_stats_type of flow_action_entry to FLOW_ACTION_HW_STATS_ANY to
> > > follow the driver behavior.
> > Now you have to explain me how you are going to use this.
> > 
> > There is no support for packet/bytes stats right now.
> > 
> > Thank you.
> 
> The FLOW_ACTION_HW_STATS_ANY flags is the default behavior and
> can avoid the failure of flow inserting. We don't nedd to use this.

OK, no worries, I'll keep back this patch. Thank you.