From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
"Florian Westphal" <fw@strlen.de>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org, "Chenbo Feng" <fengc@google.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Willem de Bruijn" <willemb@google.com>
Subject: Re: [PATCH] iptables: open eBPF programs in read only mode
Date: Thu, 26 Mar 2020 14:59:59 +0100 [thread overview]
Message-ID: <20200326135959.tqy5i4qkxwcqgp5y@salvia> (raw)
In-Reply-To: <20200320030015.195806-1-zenczykowski@gmail.com>
On Thu, Mar 19, 2020 at 08:00:15PM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Adjust the mode eBPF programs are opened in so 0400 pinned bpf programs
> work without requiring CAP_DAC_OVERRIDE.
Unfortunately this is breaking stuff:
libxt_bpf.c: In function ‘bpf_obj_get_readonly’:
libxt_bpf.c:70:6: error: ‘union bpf_attr’ has no member named ‘file_flags’
70 | attr.file_flags = BPF_F_RDONLY;
| ^
libxt_bpf.c:70:20: error: ‘BPF_F_RDONLY’ undeclared (first use in this function)
70 | attr.file_flags = BPF_F_RDONLY;
| ^~~~~~~~~~~~
next prev parent reply other threads:[~2020-03-26 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 3:00 [PATCH] iptables: open eBPF programs in read only mode Maciej Żenczykowski
2020-03-26 13:59 ` Pablo Neira Ayuso [this message]
2020-03-26 14:08 ` Maciej Żenczykowski
2020-03-26 14:13 ` Maciej Żenczykowski
2020-03-26 14:16 ` Maciej Żenczykowski
2020-03-26 14:19 ` Maciej Żenczykowski
2020-03-26 14:28 ` [PATCH v2] " Maciej Żenczykowski
2020-03-26 18:30 ` Jakub Kicinski
2020-03-26 18:34 ` Maciej Żenczykowski
2020-03-26 19:22 ` Alexei Starovoitov
2020-03-26 14:22 ` [PATCH] " Pablo Neira Ayuso
2020-03-31 16:07 ` [PATCH v3] " Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326135959.tqy5i4qkxwcqgp5y@salvia \
--to=pablo@netfilter.org \
--cc=ast@kernel.org \
--cc=fengc@google.com \
--cc=fw@strlen.de \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=willemb@google.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).