From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: Introduce test for insertion of overlapping and non-overlapping ranges
Date: Thu, 26 Mar 2020 15:08:57 +0100 [thread overview]
Message-ID: <20200326140857.cveevfqf4rvmofjj@salvia> (raw)
In-Reply-To: <a0fbd674a9df38fddd9066dd4762d551c207d66a.1583438395.git.sbrivio@redhat.com>
On Thu, Mar 05, 2020 at 09:34:11PM +0100, Stefano Brivio wrote:
> Insertion of overlapping ranges should return success only if the new
> elements are identical to existing ones, or, for concatenated ranges,
> if the new element is less specific (in all its fields) than any
> existing one.
>
> Note that, in case the range is identical to an existing one, insertion
> won't actually be performed, but no error will be returned either on
> 'add element'.
>
> This was inspired by a failing case reported by Phil Sutter (where
> concatenated overlapping ranges would fail insertion silently) and is
> fixed by kernel series with subject:
> nftables: Consistently report partial and entire set overlaps
>
> With that series, these tests now pass also if the call to set_overlap()
> on insertion is skipped. Partial or entire overlapping was already
> detected by the kernel for concatenated ranges (nft_set_pipapo) from
> the beginning, and that series makes the nft_set_rbtree implementation
> consistent in terms of detection and reporting. Without that, overlap
> checks are performed by nft but not guaranteed by the kernel.
>
> However, we can't just drop set_overlap() now, as we need to preserve
> compatibility with older kernels.
Applied, thanks.
prev parent reply other threads:[~2020-03-26 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 20:34 [PATCH nft] tests: Introduce test for insertion of overlapping and non-overlapping ranges Stefano Brivio
2020-03-26 14:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326140857.cveevfqf4rvmofjj@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).