From: Pablo Neira Ayuso <firstname.lastname@example.org> To: Stefano Brivio <email@example.com> Cc: Phil Sutter <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH nft] tests: Introduce test for insertion of overlapping and non-overlapping ranges Date: Thu, 26 Mar 2020 15:08:57 +0100 Message-ID: <20200326140857.cveevfqf4rvmofjj@salvia> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, Mar 05, 2020 at 09:34:11PM +0100, Stefano Brivio wrote: > Insertion of overlapping ranges should return success only if the new > elements are identical to existing ones, or, for concatenated ranges, > if the new element is less specific (in all its fields) than any > existing one. > > Note that, in case the range is identical to an existing one, insertion > won't actually be performed, but no error will be returned either on > 'add element'. > > This was inspired by a failing case reported by Phil Sutter (where > concatenated overlapping ranges would fail insertion silently) and is > fixed by kernel series with subject: > nftables: Consistently report partial and entire set overlaps > > With that series, these tests now pass also if the call to set_overlap() > on insertion is skipped. Partial or entire overlapping was already > detected by the kernel for concatenated ranges (nft_set_pipapo) from > the beginning, and that series makes the nft_set_rbtree implementation > consistent in terms of detection and reporting. Without that, overlap > checks are performed by nft but not guaranteed by the kernel. > > However, we can't just drop set_overlap() now, as we need to preserve > compatibility with older kernels. Applied, thanks.
prev parent reply index Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-05 20:34 Stefano Brivio 2020-03-26 14:08 ` Pablo Neira Ayuso [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200326140857.cveevfqf4rvmofjj@salvia \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Netfilter-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \ email@example.com public-inbox-index netfilter-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git