From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C07C43331 for ; Sun, 29 Mar 2020 15:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 026EC206F6 for ; Sun, 29 Mar 2020 15:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728256AbgC2PIA (ORCPT ); Sun, 29 Mar 2020 11:08:00 -0400 Received: from correo.us.es ([193.147.175.20]:57950 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727167AbgC2PIA (ORCPT ); Sun, 29 Mar 2020 11:08:00 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D12A9D2DA0F for ; Sun, 29 Mar 2020 17:07:56 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C4294FC55B for ; Sun, 29 Mar 2020 17:07:56 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id B9F70DA736; Sun, 29 Mar 2020 17:07:56 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 02A8ADA736; Sun, 29 Mar 2020 17:07:55 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sun, 29 Mar 2020 17:07:55 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D20DA42EF42A; Sun, 29 Mar 2020 17:07:54 +0200 (CEST) Date: Sun, 29 Mar 2020 17:07:54 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next 0/4] netfilter: nf_queue: rework refcount handling Message-ID: <20200329150754.hxm7y4n3etdwlhxy@salvia> References: <20200327022449.7411-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327022449.7411-1-fw@strlen.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Mar 27, 2020 at 03:24:45AM +0100, Florian Westphal wrote: [...] > This series fixes this by deferring the call to > nf_queue_entry_release_refs() until after the hook iteration/okfn > returns; i.e. another nf_queue invocation from nf_reinject path will > not observe a zero refcount. Applied.