From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D1AC83001 for ; Tue, 28 Apr 2020 00:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16CB12078C for ; Tue, 28 Apr 2020 00:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726363AbgD1AF2 (ORCPT ); Mon, 27 Apr 2020 20:05:28 -0400 Received: from correo.us.es ([193.147.175.20]:59034 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgD1AF2 (ORCPT ); Mon, 27 Apr 2020 20:05:28 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id CD027E16F3 for ; Tue, 28 Apr 2020 02:05:27 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C0C2ABAAB5 for ; Tue, 28 Apr 2020 02:05:27 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id B4D53BAAB1; Tue, 28 Apr 2020 02:05:27 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D0C3EBAC2F; Tue, 28 Apr 2020 02:05:25 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 28 Apr 2020 02:05:25 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id B0D9042EF9E0; Tue, 28 Apr 2020 02:05:25 +0200 (CEST) Date: Tue, 28 Apr 2020 02:05:25 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , Florian Westphal , Linux Network Development Mailing List , Netfilter Development Mailing List Subject: Re: [PATCH] iptables: flush stdout after every verbose log. Message-ID: <20200428000525.GD24002@salvia> References: <20200421081542.108296-1-zenczykowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200421081542.108296-1-zenczykowski@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Apr 21, 2020 at 01:15:42AM -0700, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Ensures that each logged line is flushed to stdout after it's > written, and not held in any buffer. > > Places to modify found via: > git grep -C5 'fputs[(]buffer, stdout[)];' > > On Android iptables-restore -v is run as netd daemon's child process > and fed actions via pipe. '#PING' is used to verify the child > is still responsive, and thus needs to be unbuffered. > > Luckily if you're running iptables-restore in verbose mode you > probably either don't care about performance or - like Android > - actually need this. Could you check if this slows down iptables-restore? Thank you.