From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
netfilter-devel@vger.kernel.org, jiri@resnulli.us,
kuba@kernel.org
Subject: Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling
Date: Thu, 7 May 2020 17:32:31 +0200 [thread overview]
Message-ID: <20200507153231.GA10250@salvia> (raw)
In-Reply-To: <49176c41-3696-86d9-f0eb-c20207cd6d23@solarflare.com>
On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote:
> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that
> drivers and __flow_action_hw_stats_check can use simple bitwise checks.
You have have to explain why this makes sense in terms of semantics.
_DISABLED and _ANY are contradicting each other.
> In mlxsw we check for DISABLED first, because we'd rather save the counter
> resources in the DONT_CARE case.
And this also is breaking netfilter again.
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
> Compile tested only.
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 8 ++++----
> include/net/flow_offload.h | 8 ++++----
Turning DONT_CARE gives us nothing back at all.
next prev parent reply other threads:[~2020-05-07 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 14:59 [RFC PATCH net] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-07 15:32 ` Pablo Neira Ayuso [this message]
2020-05-07 15:49 ` Edward Cree
2020-05-07 16:46 ` Pablo Neira Ayuso
2020-05-07 23:48 ` Jakub Kicinski
2020-05-11 5:33 ` Jiri Pirko
2020-05-11 10:09 ` Edward Cree
2020-05-07 15:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507153231.GA10250@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).