From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
"Florian Westphal" <fw@strlen.de>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
"Netfilter Development Mailing List"
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] iptables: flush stdout after every verbose log.
Date: Mon, 11 May 2020 14:10:53 +0200 [thread overview]
Message-ID: <20200511121053.GA22168@salvia> (raw)
In-Reply-To: <20200421081542.108296-1-zenczykowski@gmail.com>
On Tue, Apr 21, 2020 at 01:15:42AM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Ensures that each logged line is flushed to stdout after it's
> written, and not held in any buffer.
>
> Places to modify found via:
> git grep -C5 'fputs[(]buffer, stdout[)];'
>
> On Android iptables-restore -v is run as netd daemon's child process
> and fed actions via pipe. '#PING' is used to verify the child
> is still responsive, and thus needs to be unbuffered.
>
> Luckily if you're running iptables-restore in verbose mode you
> probably either don't care about performance or - like Android
> - actually need this.
Applied, thanks for explaning.
next prev parent reply other threads:[~2020-05-11 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:15 [PATCH] iptables: flush stdout after every verbose log Maciej Żenczykowski
2020-04-28 0:05 ` Pablo Neira Ayuso
2020-04-28 0:14 ` Maciej Żenczykowski
2020-04-28 22:30 ` Pablo Neira Ayuso
2020-05-09 19:30 ` Maciej Żenczykowski
2020-05-11 12:10 ` Pablo Neira Ayuso [this message]
2020-05-11 15:40 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511121053.GA22168@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).